Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

flit and flit_core can be out of sync #529

Open
pmeier opened this issue Feb 22, 2022 · 3 comments
Open

flit and flit_core can be out of sync #529

pmeier opened this issue Feb 22, 2022 · 3 comments

Comments

@pmeier
Copy link

pmeier commented Feb 22, 2022

For example

$ pip install flit==3.6.0
[...]
$ python -c "import flit_core; print(flit_core.__version__)"
3.7.0

This was detected, because the 3.7.0 release broke some build workflows (still investigating what exactly happened, see omnilib/ufmt#56) although flit==3.6.0 is pinned.

@takluyver
Copy link
Member

Sorry about that.

I'm not sure that 'out of sync' is really the problem, though - I think the changes in #499 may simply have broken it for you.

I don't think your pinning in requirements-dev.txt affects this at all: pre-commit uses pip install . which will look at pyproject.toml, and set up an isolated build environment with flit_core according to the [build-system] table.

@pmeier
Copy link
Author

pmeier commented Feb 22, 2022

I don't think your pinning in requirements-dev.txt affects this at all: pre-commit uses pip install . which will look at pyproject.toml, and set up an isolated build environment with flit_core according to the [build-system] table.

True. The pinning would only solve this for the development environment.

@takluyver
Copy link
Member

The breakage you're seeing has just been reported as #530. I'll leave this one open for the lower-priority discussion about what the dependency relationship between flit and flit_core should be.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants