Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better support of output directories #175

Open
1 of 3 tasks
jaraco opened this issue Aug 21, 2022 · 1 comment
Open
1 of 3 tasks

Better support of output directories #175

jaraco opened this issue Aug 21, 2022 · 1 comment

Comments

@jaraco
Copy link
Member

jaraco commented Aug 21, 2022

I think what this function is really trying to achieve is to ensure that object filenames are stored somewhere in the "output_dir", even if the source files are indicated by an absolute path. According to the docs, the files should be stored relative to their originally specified path in the output dir, but that example only considers relative paths. And to make matters worse, the default output dir is "", meaning the current working directory.

I think three things need to happen:

  • Remove the deprecation warning.
  • Instead of simply replacing an absolute path with a relative one, calculate the best path relative to the output dir (so a temp path doesn't appear twice).
  • If an output dir is not specified, the output dir should default to the dir where the source file is found.

Originally posted by @jaraco in #169 (comment)

@jaraco
Copy link
Member Author

jaraco commented Aug 21, 2022

There were several problems identified in #169, including that temp paths get duplicated, causing very long, sometimes invalid paths.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant