Fix, again, finding headers during cross compiling #173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for this and thanks for linking to the issue. It sure would be nice if the test suite contained either unit tests or integration tests that captured some of the cross-compiling requirements. As it is, the code is the spec, so it's difficult to safely refactor. |
jaraco
added a commit
that referenced
this pull request
Aug 21, 2022
Fix, again, finding headers during cross compiling
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Find the correct headers (from the host machine, not build) when cross compiling.
This should have been fixed in #145 but a follow up commit broke it again.
Note: I tested that normal and cross compilation of a package with native extensions succeed on a POSIX system.