Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the ecosystem convention for naming directories #141

Open
kmod opened this issue May 10, 2022 · 2 comments
Open

Use the ecosystem convention for naming directories #141

kmod opened this issue May 10, 2022 · 2 comments

Comments

@kmod
Copy link

kmod commented May 10, 2022

#133 was recently merged, and it's great to see better support for alternative Python implementations, but unfortunately it was implemented in a way that is distinct from what I've seen in the rest of the community.

In particular the issue is the usage of sys.cache_tag for naming implementation directories. This works but is a deviation from the community norm of using sysconfig.get_config_var("VERSION"): for example see build_scripts.py from this repo and the uwsgi build system. This is workable for an alternative implementation as long as we set sys.cache_tag = sysconfig.get_config_var("VERSION"), which I guess isn't the end of the world, but I believe the correct resolution is to use the appropriate configuration flag.

I'd like to advocate for #107 being merged, which simply means replacing sys.cache_tag with sysconfig.get_config_var("VERSION") in #133.

@jaraco
Copy link
Member

jaraco commented Jun 6, 2022

Unfortunately, I don't have a strong opinion on the right thing to do here.

@mgorny Do you have an opinion on kmod's proposal?

@mgorny
Copy link
Contributor

mgorny commented Jun 6, 2022

I don't think that this is going to work.

$ python3.9 -c 'import sysconfig; print(sysconfig.get_config_var("VERSION"))'
3.9
$ pypy3.9 -c 'import sysconfig; print(sysconfig.get_config_var("VERSION"))'
3.9

Unlike #133, it doesn't give unique directories for alternate interpreters.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants