Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Idea: build from SDists #597

Closed
henryiii opened this issue Feb 16, 2021 · 2 comments · Fixed by #1096
Closed

Idea: build from SDists #597

henryiii opened this issue Feb 16, 2021 · 2 comments · Fixed by #1096

Comments

@henryiii
Copy link
Contributor

Just an idea, but how about allowing the "source dir" to be (a possibly remote?) SDist? If you separate the build into a different repository, having a way to put a SDist path, or simply require a user to download an SDist then put it in as a path would negate most of the need for "astrofrog/autowheel", which doesn't seem to be maintained. Just a thought.
@mayeut
Copy link
Member

mayeut commented May 14, 2021

That's a great idea.

Even in simpler workflows than the one suggested, it would undoubtedly simplify some CI workflows.
I'm sure I'm not the only one to have a specific path to test the SDist is valid and can be used. Having this feature would allow to get rid of this, the SDist would be validated by cibuildwheel.

see also:
https://discuss.python.org/t/should-building-wheels-from-sdists-be-recommended-behavior/8358/20
pypa/build#257

This was referenced Jun 16, 2021
Open
Merged
@nsoranzo nsoranzo mentioned this issue Jan 18, 2022
Open
pombredanne added a commit to pombredanne/cibuildwheel that referenced this issue Feb 11, 2022
@pombredanne
Support building from an sdist archive
8f74b1b 
It is now possible to call the cibuildwheel command line and point it
to a package source distribution archive tarball (sdist) instead of
only a directory.

Reference: pypa#597
Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
@pombredanne pombredanne mentioned this issue Feb 11, 2022
Closed
@pombredanne
Copy link

I pushed a minimally working branch that works super simply: the "package_dir" CLI argument can now be an sdist tarball and will be used to build the wheel if provided. It only works with the pip build backend (and not "build").
See #1020
Feedback mucho welcomed.

@pombredanne pombredanne mentioned this issue Feb 11, 2022
Closed
pombredanne added a commit to pombredanne/cibuildwheel that referenced this issue Feb 11, 2022
@pombredanne
Support building from an sdist archive
3cb0d27 
It is now possible to call the cibuildwheel command line and point it
to a package source distribution archive tarball (sdist) instead of
only a directory.

Reference: pypa#597
Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
pombredanne added a commit to pombredanne/cibuildwheel that referenced this issue Feb 11, 2022
@pombredanne
Support building from an sdist archive
f951a34 
It is now possible to call the cibuildwheel command line and point it
to a package source distribution archive tarball (sdist) instead of
only a directory.

Reference: pypa#597
Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
pombredanne added a commit to pombredanne/cibuildwheel that referenced this issue Feb 15, 2022
@pombredanne
Support building from an sdist archive
15ffe9c 
It is now possible to call the cibuildwheel command line and point it
to a package source distribution archive tarball (sdist) instead of
only a directory. The sdist must be a .tar.gz tarball and will be
extracted in place before being built.

Reference: pypa#597
Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
pombredanne added a commit to pombredanne/cibuildwheel that referenced this issue Feb 15, 2022
@pombredanne
Support building from an sdist archive
08fc58d 
It is now possible to call the cibuildwheel command line and point it
to a package source distribution archive tarball (sdist) instead of
only a directory. The sdist must be a .tar.gz tarball and will be
extracted in place before being built.

Reference: pypa#597
Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
@joerick joerick mentioned this issue Apr 3, 2022
Closed
@williamjacksn williamjacksn mentioned this issue Apr 19, 2022
Open
@henryiii henryiii linked a pull request Apr 28, 2022 that will close this issue
feat: SDist builds #1096
Merged
@ajfriend ajfriend mentioned this issue Jun 2, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@pombredanne @henryiii @mayeut