You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
And it seems to be running the tests when building on these platforms. In theory, I would have expected it to merge config settings by key. Instead it seems to be appending strings.
Build (and now pip) will make a list if it gets the same value several times, that's how you make lists. So this produces {"cmake.define.RUN_CMAKE_TEST": ["ON", "OFF"]}, which seems to count for me as true.
Description
I think I see a problem with override merging. I've set the following in TOML:
And got:
And it seems to be running the tests when building on these platforms. In theory, I would have expected it to merge config settings by key. Instead it seems to be appending strings.
Build (and now pip) will make a list if it gets the same value several times, that's how you make lists. So this produces
{"cmake.define.RUN_CMAKE_TEST": ["ON", "OFF"]}
, which seems to count for me as true.I have a feeling that this was broken by #1730 (comment).
Build log
https://github.com/scikit-build/cmake-python-distributions/actions/runs/8609018236
CI config
No response
The text was updated successfully, but these errors were encountered: