Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@v2 doesn't exist #1777

Open
elalish opened this issue Mar 4, 2024 · 3 comments
Open

@v2 doesn't exist #1777

elalish opened this issue Mar 4, 2024 · 3 comments

Comments

@elalish
Copy link

elalish commented Mar 4, 2024

Description

With every other action I've used, you can specify e.g. pypa/cibuildwheel@v2 to automatically get the latest 2.x.x version that's published. However, this technique fails with this package, requiring something like pypa/cibuildwheel@v2.15.0, which just bit us because it failed, needing the update in v2.16.5, which would have been nice to get automatically.

Is this intentional?

Build log

No response

CI config

No response

@henryiii
Copy link
Contributor

henryiii commented Mar 4, 2024

You can use v2.16, we provide that. We add and remove wheels in minor releases so it’s not safe to pin to v2.

@elalish
Copy link
Author

elalish commented Mar 5, 2024

Okay, thanks. I don't fully understand, but might be nice to call out in the docs since it's different than all the other github actions versioning.

@henryiii
Copy link
Contributor

henryiii commented Mar 5, 2024

The official actions have a private action they use to create the "v2" style versions. Some other actions try to follow this, some use different names (https://github.com/pypa/gh-action-pypi-publish uses release/v1, for example), and some do not provide these at all (https://github.com/pre-commit/action, for example).

Pointing this out more clearly (and maybe using it in more places) does sound like a good idea.

The recent issue with GHA upgrading powershell to a version that broke us serves as a reminder that GHA does not provide a "stable" platform that will work even will full pinning. I think that's good (way better than stable but forever frozen and buggy platforms), but it does mean that pinning to a patch version isn't always that helpful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants