Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow copying artifacts to /output in case of test failure on docker #1756

Open
kunitoki opened this issue Feb 6, 2024 · 0 comments
Open

Comments

@kunitoki
Copy link

kunitoki commented Feb 6, 2024

Description

I am running rendering tests in cibuildwheel on all platforms, and while macOS and Windows can access the project folder easily, on linux because we run in a docker, the only place we can access generated artifacts during the build/testing phase is by copying them into /output.

The problem arises from the fact that if the tests fails (rendering tests compares generated images with reference ones in the project folder), i will have my generated images and diff images that i place in /output but this will never hit because the test failure generated a CalledProcessError and terminated the loop.

Would it be possible to add a feature to be able to extract artifacts in case of failures as well ?

Build log

No response

CI config

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant