Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

package-dir input of the GitHub Action shouldn't imply building only from a Git checkout #1682

Open
webknjaz opened this issue Nov 27, 2023 · 1 comment

Comments

@webknjaz
Copy link
Member

Description

$sbj.
https://github.com/pypa/cibuildwheel/blob/a4f8eb3/action.yml#L5 says it's a dir. But it's actually passed in place where an sdist would work too https://github.com/pypa/cibuildwheel/blob/a4f8eb3/action.yml#L40.

Build log

No response

CI config

No response

@joerick
Copy link
Contributor

joerick commented Jan 26, 2024

We can rename the option to package and update the docs but we'd need to be really careful to keep package-dir working. The action.yml isn't tested in CI and a lot of workflows would break if we got that wrong!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants