Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Testing Linux wheels on Windows host (via Docker) #1572

Closed
MBS9 opened this issue Aug 13, 2023 · 3 comments
Closed

Testing Linux wheels on Windows host (via Docker) #1572

MBS9 opened this issue Aug 13, 2023 · 3 comments

Comments

@MBS9
Copy link
Contributor

MBS9 commented Aug 13, 2023

Description

Hi all!

Thanks so much for building this wonderful project! It helps a lot in building wheels.

While testing the tool locally on my Windows laptop, I found that while I can build Linux wheels using containers, the test setup doesn't seem to work.

Here is the output from repair & test which shows the error:

Repairing wheel...

    + sh -c 'auditwheel repair -w /tmp/cibuildwheel/repaired_wheel /tmp/cibuildwheel/built_wheel/krptn-0.7.0-cp39-cp39-linux_x86_64.whl'
INFO:auditwheel.main_repair:Repairing krptn-0.7.0-cp39-cp39-linux_x86_64.whl
INFO:auditwheel.wheeltools:Previous filename tags: linux_x86_64
INFO:auditwheel.wheeltools:New filename tags: manylinux_2_17_x86_64, manylinux2014_x86_64
INFO:auditwheel.wheeltools:Previous WHEEL info tags: cp39-cp39-linux_x86_64
INFO:auditwheel.wheeltools:New WHEEL info tags: cp39-cp39-manylinux_2_17_x86_64, cp39-cp39-manylinux2014_x86_64
INFO:auditwheel.main_repair:
Fixed-up wheel written to /tmp/cibuildwheel/repaired_wheel/krptn-0.7.0-cp39-cp39-manylinux_2_17_x86_64.manylinux2014_x86_64.whl
    + /opt/python/cp38-cp38/bin/python -c 'import sys, json, glob; json.dump(glob.glob('"'"'/tmp/cibuildwheel/repaired_wheel/*.whl'"'"'), sys.stdout)'

                                                                       ✓ 0.71s
Testing wheel...

    + pip install virtualenv -c '\constraints.txt'
ERROR: Could not open requirements file: [Errno 2] No such file or directory: '\\constraints.txt'

                                                                       ✕ 1.80s
Error: Command ['pip', 'install', 'virtualenv', '-c', PureWindowsPath('/constraints.txt')] failed with code 1.

Based on what I see in the error above, it seems like CI Build Wheel is using a PureWindowsPath to reference the contraints.txt file inside a Linux container. This fails since the linux container uses Linux and hence PureWindowsPath should be PurePosixPath (or something like that).

If the CI Build Wheel team agrees, I would love to open a pull request to fix this. I have traced that this path is constructed here, and would be happy to change that code to use PurePosixPath (and any other changes which need making), as opposed to PurePath (which will use Windows Paths since its running on Windows host).

Thanks, a lot, in advance!

Build log

No response

CI config

No response

@mayeut
Copy link
Member

mayeut commented Aug 13, 2023

Hi @MBS9,
your analysis seems to be the right one.
This location was missed in #1117
You can go ahead and open a Pull Request.
Thanks

@MBS9
Copy link
Contributor Author

MBS9 commented Aug 13, 2023

Hi @mayeut ! Thanks for your quick response! I opened PR #1573

Let me know if something needs change in the PR!

@MBS9
Copy link
Contributor Author

MBS9 commented Aug 14, 2023

Thank you for merging the PR. I’ll now close this issue.

@MBS9 MBS9 closed this as completed Aug 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants