Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bot] Update dependencies #1371

Merged
merged 2 commits into from Dec 24, 2022
Merged

[Bot] Update dependencies #1371

merged 2 commits into from Dec 24, 2022

Conversation

cibuildwheel-bot[bot]
Copy link
Contributor

@cibuildwheel-bot cibuildwheel-bot bot commented Dec 11, 2022

Update the versions of our dependencies.

PR generated by "Update dependencies" workflow.

@EwoutH
Copy link

EwoutH commented Dec 12, 2022

Awesome, would it be possible to get this in sooner than later? Especially Python 3.11.1 has some important bug fixes.

@henryiii
Copy link
Contributor

PyPy has to be worked out. The latest release is broken for older macOS.

@henryiii
Copy link
Contributor

Does 3.11.1 really matter for building? It's ABI stable with RC 1, so it shouldn't matter which one you build with. Unless a runtime bug actively interferes with the build.

@EwoutH
Copy link

EwoutH commented Dec 14, 2022

Unless a runtime bug actively interferes with the build.

It's indeed ABI stable, unfortunately I have one project for which this is the case.

@joerick
Copy link
Contributor

joerick commented Dec 22, 2022

I expect that manylinux has pypy v7.3.10, so if we wanted to release the 3.11.1 update we'd have to release with mismatched pypy versions - pypy v7.3.9 on mac and v7.3.10 on linux/windows.

There shouldn't be any ABI stability issues so that's probably better than waiting for v7.3.11 IMO.

@henryiii
Copy link
Contributor

We could probably move forward then, and have weird version numbers - 7.3.9 for PyPy 3.7 & macOS, and 7.3.10 otherwise. Probably okay for a patch release. Then we could do a minor release bringing it up to 7.3.11 & macOS ARM. Maybe dropping PyPy 3.7, too?

@joerick joerick merged commit a7e9ece into main Dec 24, 2022
@joerick joerick deleted the update-dependencies-pr branch December 24, 2022 15:18
@joerick
Copy link
Contributor

joerick commented Dec 24, 2022

@EwoutH that's released as v2.11.4 now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants