Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggest running abi3audit in docs #1347

Merged
merged 4 commits into from Dec 11, 2022
Merged

Suggest running abi3audit in docs #1347

merged 4 commits into from Dec 11, 2022

Conversation

hauntsaninja
Copy link
Contributor

Suggested in #1342

@Czaki
Copy link
Contributor

Czaki commented Nov 22, 2022

could this be used in repair-wheel-command? If Yes, then maybe suggest this in docs?

@hauntsaninja
Copy link
Contributor Author

hauntsaninja commented Nov 22, 2022

I think specifying it in repair-wheel-command would override the default of running auditwheel / delocate-wheel instead of running abi3audit in addition, which would be undesirable? I guess you could chain with && but then you'd have to specify the platform overrides that cibuildwheel otherwise takes care of for you.

@henryiii
Copy link
Contributor

You'd want to && them (or make a TOML list).

@henryiii
Copy link
Contributor

It would be another example here: https://cibuildwheel.readthedocs.io/en/stable/options/#repair-wheel-command

(we used to have a mutli-line option there before, it would be nice to have an example like that again)

@hauntsaninja
Copy link
Contributor Author

Unless I'm messing up how I'm running abi3audit, I think this is blocked on trailofbits/abi3audit#23

@joerick
Copy link
Contributor

joerick commented Dec 4, 2022

Looks like that issue was fixed - are you able to incorporate the above @hauntsaninja ?

docs/faq.md Outdated Show resolved Hide resolved
docs/options.md Outdated Show resolved Hide resolved
hauntsaninja and others added 2 commits December 5, 2022 13:27
Co-authored-by: Joe Rickerby <joerick@mac.com>
Copy link
Contributor

@joerick joerick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Many thanks!

@joerick joerick merged commit c8a2671 into pypa:main Dec 11, 2022
@hauntsaninja hauntsaninja deleted the abi3audit branch December 11, 2022 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants