Add test failure with descriptive error message when running tests without a {project} placeholder #1336
+80
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…thout a {project} placeholder
joerick
force-pushed
the
test-cwd-error-message
branch
from
3072bad
to
e4cbe81
Compare
|
@henryiii any chance of a review on this one too? :) |
|
Ahh, I thought this was a |
henryiii
reviewed
Dec 5, 2022
| # pytest is run from there | ||
|
|
||
|
|
||
| def test(): |
There was a problem hiding this comment.
This assumes pytest. Would it make more sense to write it in unittest, which pytest will also pick up and run? I'm assuming this still won't get other testing frameworks (like ward), but this might be better than just assuming pytest?
There was a problem hiding this comment.
good idea! I'll try that
henryiii
reviewed
Dec 5, 2022
henryiii
approved these changes
Dec 5, 2022
joerick
added
the
automerge
|
Travis is having a slow day today 😴 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #621