Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs for native arm building on circleci #1307

Merged
merged 5 commits into from Oct 13, 2022
Merged

docs for native arm building on circleci #1307

merged 5 commits into from Oct 13, 2022

Conversation

minrk
Copy link
Contributor

@minrk minrk commented Oct 12, 2022

  • add note in docs that pyzmq uses both github and circleci, and that it includes native linux arm builds on circle
  • add linux-aarch64-wheels job to circleci-minimal example

closes #1241

@minrk minrk mentioned this pull request Oct 12, 2022
Closed
@joerick
Copy link
Contributor

joerick commented Oct 12, 2022

Brilliant, thank you @minrk! This was next on my todo list :). This is another great resource for those building aarch64, alongside the new Cirrus CI support.

joerick
joerick reviewed Oct 12, 2022
View reviewed changes
Copy link
Contributor

@joerick joerick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given CircleCI's slightly unusual docker support, would you mind configuring our CI to run the tests in .circleci/config.yml? Given your success with zmq already, I don't expect any issues, but I think it would be prudent.

@joerick
Copy link
Contributor

joerick commented Oct 12, 2022

Examples test run

Branch: example-config-test---circle-aarch64-2022-10-12T08-10-50

Service Config Status
circleci examples/circleci-minimal.yml CircleCI

Generated by bin/run_example_ci_config.py

@minrk
Copy link
Contributor Author

minrk commented Oct 12, 2022

added circleci linux-aarch64 job

@joerick joerick merged commit bea8df9 into pypa:main Oct 13, 2022
@minrk minrk deleted the circle-aarch64 branch October 14, 2022 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joerick joerick joerick approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CircleCI + native aarch64 linux buils work, how to document this?
2 participants
@minrk @joerick