feature: allow testing cp38-macosx_arm64 wheel #1283
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Per discussion in pypa#1169, the default installer used for cp38 is an Intel installer. It makes sense to skip testing arm64 wheels in this case. However, if the user choose to manually install the universal2 CPython version, then, tests shall be run on arm64. This allows users that either target 11.0+ on intel, universal2 or only build for arm64 to get the arm64 wheel tested on AppleSilicon.
for more information, see https://pre-commit.ci
|
I've got an idea here. I'll try to get to it in a day or so. |
|
Thanks @mayeut. This provides a workaround for users with compiled dependencies that need native arm64 builds. I'm curious what @henryiii has in mind also...
Yeah, maybe. I'll save a full review until I've seen the approach henryiii has in mind. We could also limit the cp38-arm64 test job to test_0_basic, test_testing, test_macos_archs to save some CI time. |
henryiii
approved these changes
Oct 1, 2022
joerick
approved these changes
Oct 4, 2022
|
Thank you @mayeut! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per discussion in #1169, the default installer used for cp38 is an Intel installer. It makes sense to skip testing arm64 wheels in this case.
However, if the user choose to manually install the universal2 CPython version (c.f. #1278 (comment)), then, tests shall be run on arm64.
This allows users that either target 11.0+ on intel, universal2 or only build for arm64 to get the arm64 wheel tested on AppleSilicon.
I'm not a fan of the way I added the test here but there's a test. Maybe the test suite should be updated to run fully with both installers ?