fix: better cross-platform auto archs #1266
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This improves the default arch selection when targeting a different platform.
If you run
cibuildwheel --platform linux --print-build-identifiers
from 64-bit Windows, I'd expect to see the identifiers for 64/32-bit Linux. I noticed this because I rancibuildwheel --platform windows --print-build-identifiers
from macOS, and got nothing - I expected the 64/32-bit Windows identifiers. However, this does work if you run macos from linux, or vs. versa, as long as you are on Intel, due to a quirk of the names.I've just fixed the auto arch discovery to be based on the target platforms's matching architecture.
auto
now uses the target OS instead of the current OS to compute the auto architectures.(This also happens to be a bit nicer for #1261. It also should be much nicer when using
--platform linux
to do builds with Docker from Windows!)