feat: support config-settings #1244
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com> feat: support config-settings Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com>
|
This looks good to me! Only thing I'm wondering about is, since the values use double-quotes and shlex.split, what happens with a config like this: [tool.cibuildwheel.config-settings]
example = "a string with \"some quotes\" in it"I don't know if that works, but... maybe that's an evil/unrealistic input, so if it's awkward to support we could just raise an error when a config-settings value has a double-quote in it (and request the user raise an issue on the tracker). |
|
Would it be better to use |
|
Yeah I think shlex.quote would work better. I think that shlex.split and shlex.quote should roundtrip perfectly. |
Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com>
joerick
approved these changes
Sep 4, 2022
Open
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #1227. Don't have much for tests yet, open to ideas.