Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: don't build universal2 as a default on macOS arm64 runners #1217

Merged
merged 3 commits into from Aug 9, 2022

Conversation

mayeut
Copy link
Member

@mayeut mayeut commented Aug 6, 2022

Per discussion in #1204, only build arm64 on arm64 macOS runners.

Fixes #1204
Relates to #1191

@joerick
Copy link
Contributor

joerick commented Aug 8, 2022

Just pushed a few docs updates. The only other thing I was wondering about was removing this line:

f'macosx_{macosx_deployment_target.replace(".", "_")}_universal2',

...because we no longer expect it to be built by default. Or perhaps we need another parameter on expected_wheels() to enable it when we're specifying ARCH=universal2 in the tests.

@joerick
Copy link
Contributor

joerick commented Aug 8, 2022

I pushed a commit that should fix the expected_wheels thing. Of course, we'll only know once we try it on an arm64 CI, which should be coming in #1191 !

@joerick joerick merged commit 6549a90 into pypa:main Aug 9, 2022
@mayeut mayeut deleted the no-universal2 branch September 4, 2022 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Should arm64 runners build both universal2 and arm64 wheels by default?
3 participants