Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Config settings without an argument #640

Open
henryiii opened this issue Jul 6, 2023 · 0 comments
Open

Config settings without an argument #640

henryiii opened this issue Jul 6, 2023 · 0 comments

Comments

@henryiii
Copy link
Contributor

henryiii commented Jul 6, 2023

Currently, build supports argumentless config-settings:

-Csomething

Is equivalent to

-Csomething=""

(since config settings is a dict in the spec). This is used, for example, to allow --config-setting=--with-c-extensions to be supported. However, pip does not support it.

I don't have a strong option on if this should be supported or not (I think I kind of like it?), but I think we should be consistent. What do people think here? If we like supporting this, I think we should ask pip to support it too. If we don't like supporting it (if it was added by mistake, for example), we could produce a warning when it's detected describing how to write it in a pip compatible way.

See pypa/cibuildwheel#1513 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant