Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Coverage reports broken on Codecov since 10 Oct #397

Closed
layday opened this issue Oct 30, 2021 · 4 comments · Fixed by #398
Closed

Coverage reports broken on Codecov since 10 Oct #397

layday opened this issue Oct 30, 2021 · 4 comments · Fixed by #398
Labels
tests

Comments

@layday
Copy link
Member

layday commented Oct 30, 2021

Since #371, Codecov is only reporting test coverage, see https://app.codecov.io/gh/pypa/build/compare/371.
@FFY00 FFY00 added the tests label Oct 30, 2021
@FFY00
Copy link
Member

FFY00 commented Oct 30, 2021

This might be related to nedbat/coveragepy#1143, but I don't have time to investigate right now.

@layday
Copy link
Member Author

layday commented Oct 30, 2021

Hmm yes, the PR appears to have coincided with the release of coverage 6 but I don't think it's related to that issue. It looks like it's not recording coverage data for anything in the .tox folder.

@layday
Copy link
Member Author

layday commented Oct 30, 2021

Possibly nedbat/coveragepy#876.

@layday
Copy link
Member Author

layday commented Oct 30, 2021

Okay, I guess that's the same issue being described.

layday added a commit to layday/build that referenced this issue Oct 30, 2021
@layday
Fix coverage data collection
33b2b49 
Closes pypa#397.
@layday layday mentioned this issue Oct 30, 2021
Merged
layday added a commit that referenced this issue Oct 30, 2021
@layday
Fix coverage data collection
cd7ee56 
Closes #397.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix coverage data collection layday/build
2 participants
@FFY00 @layday