wheels created from `requests-cache` or `url-normalize` source distributions only contains metadata #384

benoit-pierre · 2021-10-20T13:14:31Z

▸ wget -q https://files.pythonhosted.org/packages/ec/ea/780a38c99fef750897158c0afb83b979def3b379aaac28b31538d24c4e8f/url-normalize-1.4.3.tar.gz
▸ tar xf url-normalize-1.4.3.tar.gz
▸ cd url-normalize-1.4.3
▸ python -m build --wheel
* Creating virtualenv isolated environment...
* Installing packages in isolated environment... (poetry>=0.12)
* Getting dependencies for wheel...
* Building wheel...
Successfully built url_normalize-1.4.3-py2.py3-none-any.whl
▸ unzip -l dist/url_normalize-1.4.3-py2.py3-none-any.whl
Archive:  dist/url_normalize-1.4.3-py2.py3-none-any.whl
  Length      Date    Time    Name
---------  ---------- -----   ----
     1070  1980-01-01 00:00   url_normalize-1.4.3.dist-info/LICENSE
       87  2016-01-01 00:00   url_normalize-1.4.3.dist-info/WHEEL
     3193  2016-01-01 00:00   url_normalize-1.4.3.dist-info/METADATA
      318  2016-01-01 00:00   url_normalize-1.4.3.dist-info/RECORD
---------                     -------
     4668                     4 files

No such issue when using pip:

▸ python -m pip wheel --no-deps url-normalize-1.4.3.tar.gz
Processing ./url-normalize-1.4.3.tar.gz
  File was already downloaded […]/url-normalize-1.4.3.tar.gz
  Installing build dependencies ... done
  Getting requirements to build wheel ... done
    Preparing wheel metadata ... done
Building wheels for collected packages: url-normalize
  Building wheel for url-normalize (PEP 517) ... done
  Created wheel for url-normalize: filename=url_normalize-1.4.3-py2.py3-none-any.whl size=6814 sha256=aa1858ca9e313314bb73dfcfa148ffb31e8d76fe05a725990731c7f316f632b0
  Stored in directory: […]/.cache/pip/wheels/8d/bb/29/b30564ee9ae6deb89c4aac8cf2e4f27662d9ee69d77ddab992
Successfully built url-normalize
▸ unzip -l url_normalize-1.4.3-py2.py3-none-any.whl
Archive:  url_normalize-1.4.3-py2.py3-none-any.whl
  Length      Date    Time    Name
---------  ---------- -----   ----
     1060  1980-01-01 00:00   url_normalize/__init__.py
     2306  1980-01-01 00:00   url_normalize/tools.py
     6462  1980-01-01 00:00   url_normalize/url_normalize.py
     1070  1980-01-01 00:00   url_normalize-1.4.3.dist-info/LICENSE
       87  2016-01-01 00:00   url_normalize-1.4.3.dist-info/WHEEL
     3193  2016-01-01 00:00   url_normalize-1.4.3.dist-info/METADATA
      566  2016-01-01 00:00   url_normalize-1.4.3.dist-info/RECORD
---------                     -------
    14744                     7 files

build version: 0.7.0.

The text was updated successfully, but these errors were encountered:

henryiii · 2021-10-20T13:16:41Z

Your SDist is empty. Build does Source -> SDist -> Wheel by default. You probably have an issue with your MANIFEST.in. It would be better to make proper SDists, but you can skip that by explicitly requesting --wheel.

Nevermind, you are already doing that 😳

benoit-pierre · 2021-10-20T13:18:56Z

Note that if I do build a sdist (python -m build --sdist), it's indeed missing all the Python modules.

henryiii · 2021-10-20T13:19:47Z

There is nothing inside the tar except raw Python files? No setup.py, pyproject.toml, nothing?

henryiii · 2021-10-20T13:20:46Z

Ahh, I see the problem. You are cd'ing into the wrong folder. You need to run build from the folder that contains the extra files.

henryiii · 2021-10-20T13:21:27Z

No, that's what I'm doing, not what you are doing. Just let me shut up until I know what's going on, sorry for the spam....

benoit-pierre · 2021-10-20T13:23:28Z

Additionally, building a wheel/sdist from a clone of https://github.com/niksite/url-normalize works. But if I move the .git sub-folder out of the way, same issue. Again, pip has no such issue. Which is why I'm assuming it's not a bug with the PEP 517 backend.

benoit-pierre · 2021-10-20T13:24:43Z

Is there a way to get more verbose/debug information from build?

henryiii · 2021-10-20T13:26:51Z

Poetry does use git to track what goes in instead of using a MANIFEST.in, so it could very well be a bug in poetry. Though, for me, it's working:

$ wget -q https://files.pythonhosted.org/packages/ec/ea/780a38c99fef750897158c0afb83b979def3b379aaac28b31538d24c4e8f/url-normalize-1.4.3.tar.gz
$ tar xf url-normalize-1.4.3.tar.gz
$ cd url-normalize-1.4.3
$ pipx run build --wheel
$ unzip -l dist/url_normalize-1.4.3-py2.py3-none-any.whl
Archive:  dist/url_normalize-1.4.3-py2.py3-none-any.whl
  Length      Date    Time    Name
---------  ---------- -----   ----
     1060  01-01-1980 00:00   url_normalize/__init__.py
     2306  01-01-1980 00:00   url_normalize/tools.py
     6462  01-01-1980 00:00   url_normalize/url_normalize.py
     1070  01-01-1980 00:00   url_normalize-1.4.3.dist-info/LICENSE
       87  01-01-2016 00:00   url_normalize-1.4.3.dist-info/WHEEL
     3193  01-01-2016 00:00   url_normalize-1.4.3.dist-info/METADATA
      566  01-01-2016 00:00   url_normalize-1.4.3.dist-info/RECORD
---------                     -------
    14744                     7 files

You aren't in a git tracked directory when you are doing this, are you? That will break poetry for sure, as it will assume you are trying to track the contents of the folder you are building.

benoit-pierre · 2021-10-20T13:26:52Z

There is nothing inside the tar except raw Python files? No setup.py, pyproject.toml, nothing?

▸ tar tvf dist/url-normalize-1.4.3.tar.gz
-rw-r--r-- 0/0            1070 2021-10-20 15:19 url-normalize-1.4.3/LICENSE
-rw-r--r-- 0/0            2136 2021-10-20 15:19 url-normalize-1.4.3/README.md
-rw-r--r-- 0/0            1234 2021-10-20 15:19 url-normalize-1.4.3/pyproject.toml
-rw-r--r-- 0/0            2888 2021-10-20 15:21 url-normalize-1.4.3/setup.py
-rw-r--r-- 0/0            3193 2021-10-20 15:21 url-normalize-1.4.3/PKG-INFO

benoit-pierre · 2021-10-20T13:27:35Z

My dotfiles are tracked with git. Let me check if that's indeed the issue.

layday · 2021-10-20T13:30:08Z

Is your git repo inside another git repo? Poetry might be using the outermost repo.

benoit-pierre · 2021-10-20T13:30:37Z

Yep, that's the issue. That's not great behavior on the part of poetry... Clearly I'm not the only one with this issue: see comments for https://aur.archlinux.org/packages/python-requests-cache and https://aur.archlinux.org/packages/python-url-normalize/.

benoit-pierre · 2021-10-20T13:37:12Z

Possible workaround: GIT_CEILING_DIRECTORIES="$PWD/.." python -m build --wheel

In any case, not a build bug. Cheers!

henryiii · 2021-10-20T13:39:49Z

Or

GIT_CEILING_DIRECTORIES="$PWD/.." python -m build --wheel

;)

layday · 2021-10-20T13:43:31Z

When this came up before I suggested that Poetry should disable Git detection for sdists, might be worth bringing up on their tracker.

benoit-pierre · 2021-10-20T13:45:16Z

Damn, yes, I meant with python -m build --wheel of course...

henryiii · 2021-10-20T13:46:54Z

Part of the problem is that build can't run directly on the SDist. Pip is running directly on the SDist, and therefore is probably expanding the SDist in a temporary directory, so that's why it's working with pip. If we supported similar behavior (#311), then this would have worked from build too.

benoit-pierre · 2021-10-20T13:48:43Z

But pip wheel . works fine too. Does pip still create a temporary copy? I think that's was removed.

benoit-pierre · 2021-10-20T13:50:40Z

OK, yes, pip still builds in a temporary copy located in /tmp. I think the plan is to drop that copy in a future version.

henryiii · 2021-10-20T13:51:19Z

What version of pip are you using? Isn't that in 21.3?

benoit-pierre · 2021-10-20T13:52:03Z

20.3.4 (the Arch packaged version).

henryiii · 2021-10-20T13:53:15Z

Okay, if you used 21.3, I think this would affect the pip wheel . usage identically, but not the sdist usage.

benoit-pierre · 2021-10-20T13:53:21Z

And yep, 21.3 has the same issue.

henryiii · 2021-10-20T13:54:14Z

That's reassuring, consistency is good. :)

layday · 2021-10-20T14:02:08Z

Part of the problem is that build can't run directly on the SDist. Pip is running directly on the SDist, and therefore is probably expanding the SDist in a temporary directory, so that's why it's working with pip. If we supported similar behavior (#311), then this would have worked from build too.

Even when build is invoked with --sdist --wheel (or sans args), we're unpacking the sdist in the folder where build is invoked. pip unpacks downloaded sdists in $TMPDIR prior to building a wheel.

(Edited for clarity.)

carlosal1015 · 2021-10-20T14:08:11Z

Thanks for the explanation @henryiii @benoit-pierre @layday @alex @jezdez . I am the maintainer of both packages on AUR, trying to understand how to fix the installation for everyone, thanks for the help.

henryiii · 2021-10-20T14:09:06Z

If we support running directly on <file>.tar.gz, that likely will be in the tmp folder, since there isn't a package dir in that case. (I'm also a fan of using tmp for everything, using a subfolder causes issues, including this one. Scikit-build uses a local folder and it's a constant headache, but kind of necessary for incremental builds. But doesn't mean I like it).

layday · 2021-10-20T14:14:09Z

It can be next to the tarfile ;)

henryiii · 2021-10-20T14:15:18Z

There's a difference between "can" and "should". ;)

* Change to use the python-{build,installer,wheel} utilities as specified in [0]. * Use python package naming convention as specified in [0]. * Fix build error from poetry when nested git directories [1]. [0]: https://wiki.archlinux.org/title/Python_package_guidelines [1]: pypa/build#384

benoit-pierre closed this as completed Oct 20, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

wheels created from `requests-cache` or `url-normalize` source distributions only contains metadata #384

wheels created from `requests-cache` or `url-normalize` source distributions only contains metadata #384

benoit-pierre commented Oct 20, 2021 •

edited

henryiii commented Oct 20, 2021 •

edited

benoit-pierre commented Oct 20, 2021

henryiii commented Oct 20, 2021

henryiii commented Oct 20, 2021

henryiii commented Oct 20, 2021

benoit-pierre commented Oct 20, 2021

benoit-pierre commented Oct 20, 2021

henryiii commented Oct 20, 2021

benoit-pierre commented Oct 20, 2021

benoit-pierre commented Oct 20, 2021

layday commented Oct 20, 2021

benoit-pierre commented Oct 20, 2021

benoit-pierre commented Oct 20, 2021 •

edited

henryiii commented Oct 20, 2021

layday commented Oct 20, 2021

benoit-pierre commented Oct 20, 2021

henryiii commented Oct 20, 2021

benoit-pierre commented Oct 20, 2021

benoit-pierre commented Oct 20, 2021

henryiii commented Oct 20, 2021

benoit-pierre commented Oct 20, 2021

henryiii commented Oct 20, 2021

benoit-pierre commented Oct 20, 2021

henryiii commented Oct 20, 2021

layday commented Oct 20, 2021 •

edited

carlosal1015 commented Oct 20, 2021

henryiii commented Oct 20, 2021

layday commented Oct 20, 2021

henryiii commented Oct 20, 2021

wheels created from requests-cache or url-normalize source distributions only contains metadata #384

wheels created from requests-cache or url-normalize source distributions only contains metadata #384

Comments

benoit-pierre commented Oct 20, 2021 • edited

henryiii commented Oct 20, 2021 • edited

benoit-pierre commented Oct 20, 2021

henryiii commented Oct 20, 2021

henryiii commented Oct 20, 2021

henryiii commented Oct 20, 2021

benoit-pierre commented Oct 20, 2021

benoit-pierre commented Oct 20, 2021

henryiii commented Oct 20, 2021

benoit-pierre commented Oct 20, 2021

benoit-pierre commented Oct 20, 2021

layday commented Oct 20, 2021

benoit-pierre commented Oct 20, 2021

benoit-pierre commented Oct 20, 2021 • edited

henryiii commented Oct 20, 2021

layday commented Oct 20, 2021

benoit-pierre commented Oct 20, 2021

henryiii commented Oct 20, 2021

benoit-pierre commented Oct 20, 2021

benoit-pierre commented Oct 20, 2021

henryiii commented Oct 20, 2021

benoit-pierre commented Oct 20, 2021

henryiii commented Oct 20, 2021

benoit-pierre commented Oct 20, 2021

henryiii commented Oct 20, 2021

layday commented Oct 20, 2021 • edited

carlosal1015 commented Oct 20, 2021

henryiii commented Oct 20, 2021

layday commented Oct 20, 2021

henryiii commented Oct 20, 2021

wheels created from `requests-cache` or `url-normalize` source distributions only contains metadata #384

wheels created from `requests-cache` or `url-normalize` source distributions only contains metadata #384

benoit-pierre commented Oct 20, 2021 •

edited

henryiii commented Oct 20, 2021 •

edited

benoit-pierre commented Oct 20, 2021 •

edited

layday commented Oct 20, 2021 •

edited