Steam TOTP #142
Merged
Steam TOTP #142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #142 +/- ##
===========================================
- Coverage 98.89% 98.02% -0.87%
===========================================
Files 6 8 +2
Lines 181 203 +22
Branches 38 43 +5
===========================================
+ Hits 179 199 +20
- Misses 1 3 +2
Partials 1 1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
|
Great work, thank you for your contribution! |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's basically what I have already commented on the corresponding issue (#127), but integrated into pyotp.
A new class is added in a
pyotp.contrib.steamsubmodule. It's a subclass ofpyotp.TOTPand overrides thegenerate_otpmethod. (all as mentioned in the issue here)I also added some tests and included the new class in the API Documentation section.