Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow overriding compile parameters in pywasmcross #4690

Open
joemarshall opened this issue Apr 12, 2024 · 1 comment
Open

Allow overriding compile parameters in pywasmcross #4690

joemarshall opened this issue Apr 12, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@joemarshall
Copy link
Contributor

If you are building a package using pyodide build, as default, calls to cc etc. for compiling or linking are routed via pywasmcross.py, which adds on the build options from pyodide.

If you have compile options that differ from the build options of pyodide, then pywasmcross kills them. Most obviously if you are building a package as debug against a non-debug pyodide, it adds -g0 to the command line and your debug info disappears.

I can work around this for now by changing my build to use emcc directly instead of calling cc / c++ but it would be nice if pywasmcross didn't override debug flags that were already set on the command line.

@ryanking13
Copy link
Member

Thanks for opening the issue @joemarshall. I think it makes sense. I'm planning various improvements to pyodide-build (#4557), part of which involves creating a separate config file that pyodide-build uses, which could contain compilation options.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants