Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to packaging 0.22 #36

Closed
rth opened this issue Dec 10, 2022 · 6 comments · Fixed by #49
Closed

Upgrade to packaging 0.22 #36

rth opened this issue Dec 10, 2022 · 6 comments · Fixed by #49

Comments

@rth
Copy link
Member

rth commented Dec 10, 2022

Packaging v22.0 is released and we should upgrade to it. In particular, it removes the dependency on pyparsing which is great.

Currently, it doesn't work due to a regression in pypa/packaging#638 so we either need to wait for a new release with a fix, or patch

if not req.marker or req.marker.evaluate({"extra": extra}):

but patching the vendored version of pkg_resources is not great, because it means the extra argument to pass there depends on the packaging version (which can be different inside and outside Pyodide VM). So waiting for an upstream fix would be preferable.

@mentalisttraceur
Copy link
Contributor

Re: "it removes the dependency on pyparsing": two micropip tests currently assume pyparsing is present:

await pyodide.loadPackage(["packaging", "pyparsing"]);

pyparsing_wheel_name = list(DIST_PATH.glob("pyparsing*.whl"))[0].name
selenium.run_js(
f"""
await pyodide.runPythonAsync(`
import micropip
await micropip.install('file:{pyparsing_wheel_name}')
import pyparsing

@ryanking13
Copy link
Member

In particular, it removes the dependency on pyparsing which is great.

Great news! 🎉

@rth
Copy link
Member Author

rth commented Dec 12, 2022

Yes, thanks @mentalisttraceur we would have to adapt those tests not to use pyparsing.

@rth
Copy link
Member Author

rth commented Jan 4, 2023

Currently, it doesn't work due to a regression in pypa/packaging#638

This was fixed upstream, but we would need to wait for the 0.22.1 or 0.23.0 release

@arpitnath
Copy link

@rth When can we expect the 0.22.1 or 0.23.0 release?

@ryanking13
Copy link
Member

We will release 0.22.1 when we address most of the bugs that are reported in 0.22.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants