Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-pages: stop building guide for main #2599

Merged
merged 1 commit into from Aug 28, 2022

Conversation

davidhewitt
Copy link
Member

Stop building docs and guide as part of gh-pages main jobs. Continue to build the guide (not docs) as the gh-pages versioned guides are proxied by Netlify.

I'll delete all the docs and "latest" symlink from the gh-pages branch once this is merged, and force-push that as an orphan commit. Then we should have cleaned up the repo nicely.

Closes #2472
Closes #1773

@@ -39,13 +39,6 @@ jobs:
TAG_NAME="${GITHUB_REF##*/}"
echo "::set-output name=tag_name::${TAG_NAME}"

# Build some internal docs and inject a banner on top of it.
- name: Build the internal docs
run: cargo xtask doc --internal
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that building docs is tested by the Netlify build, which does report if it fails. We could consider making a test-docs-build CI job just to make it simpler to see if docs build succeeded/failed.

Copy link
Member

@mejrs mejrs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks :)

@messense messense merged commit 511303a into PyO3:main Aug 28, 2022
@davidhewitt davidhewitt deleted the no-main-gh-pages branch August 28, 2022 07:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reduce gh-pages branch size? Guide release issue
3 participants