Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove typying #2205

Merged
merged 1 commit into from Mar 4, 2022
Merged

Remove typying #2205

merged 1 commit into from Mar 4, 2022

Conversation

JerzySpendel
Copy link
Contributor

@JerzySpendel JerzySpendel commented Mar 4, 2022 •
edited

Well, I guess it didn't make sense to add type annotation if the value was to be immediately returned?

birkenfeld
birkenfeld approved these changes Mar 4, 2022
View reviewed changes
Copy link
Member

@birkenfeld birkenfeld left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AFAICT that's invalid syntax anyway... maybe leftover from an automatic replacement?

@davidhewitt davidhewitt merged commit 576818d into PyO3:main Mar 4, 2022
@davidhewitt davidhewitt mentioned this pull request Mar 4, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@birkenfeld birkenfeld birkenfeld approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@JerzySpendel @birkenfeld @davidhewitt