allow_threads: switch from catch_unwind to guard pattern
#1990
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yay this fixes the two problems I was seeing! 1) The crash on Linux, and 2) the async thread was not actually finishing on macOS. Thank you so much 🙌 Everything now works without needing to make any more changes to Pants, woot! Thanks to Cargo's git support, once this merges, I think Pants is fully unblocked now from hitting merge on pantsbuild/pants#13526 🚀 |
|
Great! I was thinking of putting out 0.15.1 within a week anyway to include a few non-breaking additions before starting breaking stuff for 0.16, so I'll make sure to include this in that release. |
davidhewitt
force-pushed
the
allow-threads-unwind
branch
from
51b6b94
to
4e76408
Compare
davidhewitt
force-pushed
the
allow-threads-unwind
branch
from
4e76408
to
1df68e8
Compare
jsirois
added a commit
to jsirois/pants
that referenced
this pull request
Nov 28, 2021
This includes a fix we were waiting on in pantsbuild#13526: PyO3/pyo3#1990 Changelog here: https://pyo3.rs/v0.15.1/changelog.html # Building wheels and fs_util will be skipped. Delete if not intended. [ci skip-build-wheels]
jsirois
added a commit
to pantsbuild/pants
that referenced
this pull request
Nov 28, 2021
This includes a fix we were waiting on in #13526: PyO3/pyo3#1990 Changelog here: https://pyo3.rs/v0.15.1/changelog.html
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See pantsbuild/pants#13526 (comment)
I think that use of
catch_unwindinallow_threadsmay currently catch non-Rust exceptions too (it's not particularly clear), leading to nasty crashes.Switching to a guard pattern might avoid this.
cc @Eric-Arellano can you try your pants PR against this branch and see if it fixes?