Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixed markdown syntax #1196

Merged
merged 1 commit into from Sep 16, 2020
Merged

fixed markdown syntax #1196

merged 1 commit into from Sep 16, 2020

Conversation

alex
Copy link
Contributor

@alex alex commented Sep 16, 2020

No description provided.

@alex
Copy link
Contributor Author

alex commented Sep 16, 2020

Failing test must be an unrelated issue, some change in Python 3.9 I suppose.

mtreinish
mtreinish approved these changes Sep 16, 2020
View reviewed changes
Copy link
Contributor

@mtreinish mtreinish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, this was my bad. LGTM, thanks for fixing this.

davidhewitt
davidhewitt approved these changes Sep 16, 2020
View reviewed changes
Copy link
Member

@davidhewitt davidhewitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

kngwyu
kngwyu approved these changes Sep 16, 2020
View reviewed changes
Copy link
Member

@kngwyu kngwyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@kngwyu kngwyu merged commit c1b3e06 into PyO3:master Sep 16, 2020
@alex alex deleted the patch-1 branch September 16, 2020 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidhewitt davidhewitt davidhewitt approved these changes

@mtreinish mtreinish mtreinish approved these changes

@kngwyu kngwyu kngwyu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@alex @davidhewitt @mtreinish @kngwyu