Archive::Archive defined twice

[stefan6419846]

Describe the bug

Building the package reports a warning:

swig -python -o fitz/fitz_wrap.c fitz/fitz.i
fitz/fitz.i:12342: Warning 509: Overloaded method Archive::Archive(PyObject *,char const *) effectively ignored,
fitz/fitz.i:12331: Warning 509: as it is shadowed by Archive::Archive(struct Archive *,char const *).
creating build

To Reproduce

Build the wheel.

Expected behavior

No warnings are raised.

Your configuration

• OpenSUSE Leap 15.3
• PyMuPDF version 1.21.0, built from PyPI source

Additional context

Looking into the code, both definitions are mostly identical:

PyMuPDF/fitz/fitz.i

Lines 12321 to 12342 in a730bc6

	Archive(struct Archive *a0=NULL, const char *path=NULL)
	{
	fz_archive *arch=NULL;
	fz_try(gctx) {
	arch = fz_new_multi_archive(gctx);
	}
	fz_catch(gctx) {
	return NULL;
	}
	return (struct Archive *) arch;
	}
	Archive(PyObject *a0=NULL, const char *path=NULL)
	{
	fz_archive *arch=NULL;
	fz_try(gctx) {
	arch = fz_new_multi_archive(gctx);
	}
	fz_catch(gctx) {
	return NULL;
	}
	return (struct Archive *) arch;
	}

[JorjMcKie]

Thanks for reporting this. That's no problem, please ignore.

[julian-smith-artifex-com]

Further to JorjMcKie's comment, the generation of this warning seems to be a known bug in swig.

It can be disabled with swig_opts=['-w509'] in setup.py's call to Extension(); i'll push this workaround shortly.

[julian-smith-artifex-com]

Fixed in PyMuPDF-1.21.1.