Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugs with certain input data for LoewnerReductor #2245

Open
artpelling opened this issue Jan 10, 2024 · 0 comments
Open

Bugs with certain input data for LoewnerReductor #2245

artpelling opened this issue Jan 10, 2024 · 0 comments
Labels
Milestone

Comments

@artpelling
Copy link
Member

I've found several cases that lead to errors with LoewnerReductor.

from pymor.reductors.loewner import LoewnerReductor


n = 100
s = (np.arange(n)+1)*1j
Hs = np.random.rand(n, 3, 1)

# BUG 1 about types
L = LoewnerReductor(s, Hs, mimo_handling='random') # this works
#rom = L.reduce()

L = LoewnerReductor(s, Hs, mimo_handling='full') # this doesn't
#rom = L.reduce()


# BUG 2 about shapes
Hs = np.random.rand(n, 3, 1) + 1j # add 1j to make complex

L = LoewnerReductor(s, Hs) # this works
rom = L.reduce()

Hs = Hs.transpose(0, 2, 1)
L = LoewnerReductor(s, Hs) # this doesn't
rom = L.reduce()

@lbalicki We should fix those and add tests for them!

@artpelling artpelling added the bug label Jan 10, 2024
@lbalicki lbalicki self-assigned this Jan 11, 2024
@lbalicki lbalicki added this to the 2024.1 milestone Jan 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants