-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add tutorial on interpolation for LTI systems #2153
base: main
Are you sure you want to change the base?
Conversation
pmli
commented
Aug 18, 2023
•
edited
edited
- interpolation at infinity
- interpolation at zero
- interpolation at a non-zero finite point
- tangential interpolation
- structure-preserving interpolation?
004b9b2
to
d043d8e
Compare
c10d4df
to
3a64d77
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I really like the structure of the tutorial and the visualization of the different interpolation approaches, but I think a few details can be added. I would say structure-preserving interpolation and structure-preserving model reduction (e.g., second order models) for that matter could be treated in a separate tutorial.
``` | ||
|
||
to perform a (Petrov-)Galerkin projection. | ||
This will achieve interpolation of the first $2 r$ moments at infinity |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think there should be a few more details here. For example, what does the transfer function or interpolated model look like exactly after using PG projection? Maybe the interpolation which is then achieved could be written down explicitly? For someone who is new to all this, it might be very helpful to have some of these basic facts appear here.
(also known as the shifted Padé approximation). | ||
|
||
```{math} | ||
\newcommand{\H}{\operatorname{H}} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Running in binder I got the message "\newcommand{\H} attempting to redefine \H; use \renewcommand" and latex did not compile.
one idea is to do interpolation at multiple points (sometimes called *multipoint Padé*), | ||
whether of lower or higher-order. | ||
pyMOR implements bitangential Hermite interpolation (BHI) for different types of {{ Models }}. | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There should maybe again be another couple lines saying what bitangential means here or similarly some explanation of what b
and c
are in the code below.
(higher-order interpolation at single point {cite}`G97`) and | ||
then move on to bitangential Hermite interpolation | ||
which is directly supported in pyMOR. | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would possibly be helpful to write a bit more motivation for interpolatory model reduction here or in the section below. Transfer functions are known from the LTI systems tutorial. By simply pointing out the relationship between the input-output mapping which we are interested in and the transfer function it will hopefully immediately make sense why we should even care about these interpolatory methods.
3a64d77
to
d4cace0
Compare