Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve CI #946

Closed
BenediktBurger opened this issue Jul 14, 2023 · 2 comments
Closed

Improve CI #946

BenediktBurger opened this issue Jul 14, 2023 · 2 comments
Labels
discussion-needed A solution still needs to be determined duplicate enhancement

Comments

@BenediktBurger
Copy link
Member

Based on the experience of adding CI to pyleco (pymeasure/pyleco#7), I'd like to back port some ideas to pymeasure.

  • Mamba resulted in a faster setup build time, so it should be used, I think.
  • we could introduce test coverage for the instruments and adapters, or at least for the core elements, that is adapters and core instrument classes like Instrument, Channel, CommonBase.
@BenediktBurger BenediktBurger added enhancement discussion-needed A solution still needs to be determined labels Jul 14, 2023
@bilderbuchi
Copy link
Member

bilderbuchi commented Jul 14, 2023 •
edited

Good ideas! Duplicate of/better tracked in #348?

I agree, coverage on just the core makes sense, but not for instruments.

@BenediktBurger
Copy link
Member Author

Duplicate of #348 (sorry, working on the phone...)

@BenediktBurger BenediktBurger closed this as not planned Won't fix, can't repro, duplicate, stale Jul 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
discussion-needed A solution still needs to be determined duplicate enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bilderbuchi @BenediktBurger