From f07897fbc689b2eed411263865e02aecb38aef0a Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Dani=C3=ABl=20van=20Noord?= <13665637+DanielNoord@users.noreply.github.com> Date: Thu, 2 Dec 2021 16:57:07 +0100 Subject: [PATCH 01/11] Move test 1 --- tests/checkers/unittest_typecheck.py | 19 ------------------- tests/functional/n/no/no_member_imports.py | 9 +++++++++ tests/functional/n/no/no_member_imports.txt | 1 + 3 files changed, 10 insertions(+), 19 deletions(-) create mode 100644 tests/functional/n/no/no_member_imports.py create mode 100644 tests/functional/n/no/no_member_imports.txt diff --git a/tests/checkers/unittest_typecheck.py b/tests/checkers/unittest_typecheck.py index f378fc402b..f43a19230f 100644 --- a/tests/checkers/unittest_typecheck.py +++ b/tests/checkers/unittest_typecheck.py @@ -49,25 +49,6 @@ class TestTypeChecker(CheckerTestCase): "Tests for pylint.checkers.typecheck" CHECKER_CLASS = typecheck.TypeChecker - def test_no_member_in_getattr(self) -> None: - """Make sure that a module attribute access is checked by pylint.""" - - node = astroid.extract_node( - """ - import optparse - optparse.THIS_does_not_EXIST - """ - ) - with self.assertAddsMessages( - MessageTest( - "no-member", - node=node, - args=("Module", "optparse", "THIS_does_not_EXIST", ""), - confidence=INFERENCE, - ) - ): - self.checker.visit_attribute(node) - @set_config(ignored_modules=("argparse",)) def test_no_member_in_getattr_ignored(self) -> None: """Make sure that a module attribute access check is omitted with a diff --git a/tests/functional/n/no/no_member_imports.py b/tests/functional/n/no/no_member_imports.py new file mode 100644 index 0000000000..64cfccad0c --- /dev/null +++ b/tests/functional/n/no/no_member_imports.py @@ -0,0 +1,9 @@ +"""Tests for no-member on imported modules""" +# pylint: disable=import-outside-toplevel, pointless-statement + + +def test_no_member_in_getattr(): + """Make sure that a module attribute access is checked by pylint.""" + import collections + + collections.THIS_does_not_EXIST # [no-member] diff --git a/tests/functional/n/no/no_member_imports.txt b/tests/functional/n/no/no_member_imports.txt new file mode 100644 index 0000000000..18f7459152 --- /dev/null +++ b/tests/functional/n/no/no_member_imports.txt @@ -0,0 +1 @@ +no-member:9:4:9:35:test_no_member_in_getattr:Module 'collections' has no 'THIS_does_not_EXIST' member:INFERENCE From 21eec15f3925d90142290d8ab984ce8936812c44 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Dani=C3=ABl=20van=20Noord?= <13665637+DanielNoord@users.noreply.github.com> Date: Thu, 2 Dec 2021 16:58:54 +0100 Subject: [PATCH 02/11] Move test --- tests/checkers/unittest_typecheck.py | 15 --------------- tests/functional/n/no/no_member_imports.py | 9 +++++++++ tests/functional/n/no/no_member_imports.rc | 2 ++ 3 files changed, 11 insertions(+), 15 deletions(-) create mode 100644 tests/functional/n/no/no_member_imports.rc diff --git a/tests/checkers/unittest_typecheck.py b/tests/checkers/unittest_typecheck.py index f43a19230f..940e9faa1f 100644 --- a/tests/checkers/unittest_typecheck.py +++ b/tests/checkers/unittest_typecheck.py @@ -49,21 +49,6 @@ class TestTypeChecker(CheckerTestCase): "Tests for pylint.checkers.typecheck" CHECKER_CLASS = typecheck.TypeChecker - @set_config(ignored_modules=("argparse",)) - def test_no_member_in_getattr_ignored(self) -> None: - """Make sure that a module attribute access check is omitted with a - module that is configured to be ignored. - """ - - node = astroid.extract_node( - """ - import argparse - argparse.THIS_does_not_EXIST - """ - ) - with self.assertNoMessages(): - self.checker.visit_attribute(node) - @set_config(ignored_modules=("xml.etree.",)) def test_ignored_modules_invalid_pattern(self) -> None: node = astroid.extract_node( diff --git a/tests/functional/n/no/no_member_imports.py b/tests/functional/n/no/no_member_imports.py index 64cfccad0c..2e746381d9 100644 --- a/tests/functional/n/no/no_member_imports.py +++ b/tests/functional/n/no/no_member_imports.py @@ -7,3 +7,12 @@ def test_no_member_in_getattr(): import collections collections.THIS_does_not_EXIST # [no-member] + + +def test_no_member_in_getattr_ignored() -> None: + """Make sure that a module attribute access check is omitted with a + module that is configured to be ignored. + """ + import argparse + + argparse.THIS_does_not_EXIST diff --git a/tests/functional/n/no/no_member_imports.rc b/tests/functional/n/no/no_member_imports.rc new file mode 100644 index 0000000000..d4a05f1b8e --- /dev/null +++ b/tests/functional/n/no/no_member_imports.rc @@ -0,0 +1,2 @@ +[TYPECHECK] +ignored-modules=argparse From 465ac3cf6c02ec3df48f756ec700795961035527 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Dani=C3=ABl=20van=20Noord?= <13665637+DanielNoord@users.noreply.github.com> Date: Thu, 2 Dec 2021 17:00:05 +0100 Subject: [PATCH 03/11] Move test --- tests/checkers/unittest_typecheck.py | 17 ----------------- tests/functional/n/no/no_member_imports.py | 8 +++++++- tests/functional/n/no/no_member_imports.rc | 2 +- tests/functional/n/no/no_member_imports.txt | 1 + 4 files changed, 9 insertions(+), 19 deletions(-) diff --git a/tests/checkers/unittest_typecheck.py b/tests/checkers/unittest_typecheck.py index 940e9faa1f..7454a34963 100644 --- a/tests/checkers/unittest_typecheck.py +++ b/tests/checkers/unittest_typecheck.py @@ -49,23 +49,6 @@ class TestTypeChecker(CheckerTestCase): "Tests for pylint.checkers.typecheck" CHECKER_CLASS = typecheck.TypeChecker - @set_config(ignored_modules=("xml.etree.",)) - def test_ignored_modules_invalid_pattern(self) -> None: - node = astroid.extract_node( - """ - import xml - xml.etree.Lala - """ - ) - message = MessageTest( - "no-member", - node=node, - args=("Module", "xml.etree", "Lala", ""), - confidence=INFERENCE, - ) - with self.assertAddsMessages(message): - self.checker.visit_attribute(node) - @set_config(ignored_modules=("xml",)) def test_ignored_modules_root_one_applies_as_well(self) -> None: # Check that when a root module is completely ignored, submodules are skipped. diff --git a/tests/functional/n/no/no_member_imports.py b/tests/functional/n/no/no_member_imports.py index 2e746381d9..1c4f9b3096 100644 --- a/tests/functional/n/no/no_member_imports.py +++ b/tests/functional/n/no/no_member_imports.py @@ -1,5 +1,5 @@ """Tests for no-member on imported modules""" -# pylint: disable=import-outside-toplevel, pointless-statement +# pylint: disable=import-outside-toplevel, pointless-statement, missing-function-docstring def test_no_member_in_getattr(): @@ -16,3 +16,9 @@ def test_no_member_in_getattr_ignored() -> None: import argparse argparse.THIS_does_not_EXIST + + +def test_ignored_modules_invalid_pattern() -> None: + import xml + + xml.etree.Lala # [no-member] diff --git a/tests/functional/n/no/no_member_imports.rc b/tests/functional/n/no/no_member_imports.rc index d4a05f1b8e..ecf110b1cb 100644 --- a/tests/functional/n/no/no_member_imports.rc +++ b/tests/functional/n/no/no_member_imports.rc @@ -1,2 +1,2 @@ [TYPECHECK] -ignored-modules=argparse +ignored-modules=argparse,xml.etree. diff --git a/tests/functional/n/no/no_member_imports.txt b/tests/functional/n/no/no_member_imports.txt index 18f7459152..48b8c021ee 100644 --- a/tests/functional/n/no/no_member_imports.txt +++ b/tests/functional/n/no/no_member_imports.txt @@ -1 +1,2 @@ no-member:9:4:9:35:test_no_member_in_getattr:Module 'collections' has no 'THIS_does_not_EXIST' member:INFERENCE +no-member:24:4:24:18:test_ignored_modules_invalid_pattern:Module 'xml.etree' has no 'Lala' member:INFERENCE From fb4d42416b13b29889cf088b4412a98ee640da44 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Dani=C3=ABl=20van=20Noord?= <13665637+DanielNoord@users.noreply.github.com> Date: Thu, 2 Dec 2021 17:01:09 +0100 Subject: [PATCH 04/11] Move test --- tests/checkers/unittest_typecheck.py | 12 ------------ tests/functional/n/no/no_member_imports.py | 7 +++++++ 2 files changed, 7 insertions(+), 12 deletions(-) diff --git a/tests/checkers/unittest_typecheck.py b/tests/checkers/unittest_typecheck.py index 7454a34963..85c0b9f7b9 100644 --- a/tests/checkers/unittest_typecheck.py +++ b/tests/checkers/unittest_typecheck.py @@ -49,18 +49,6 @@ class TestTypeChecker(CheckerTestCase): "Tests for pylint.checkers.typecheck" CHECKER_CLASS = typecheck.TypeChecker - @set_config(ignored_modules=("xml",)) - def test_ignored_modules_root_one_applies_as_well(self) -> None: - # Check that when a root module is completely ignored, submodules are skipped. - node = astroid.extract_node( - """ - import xml - xml.etree.Lala - """ - ) - with self.assertNoMessages(): - self.checker.visit_attribute(node) - @set_config(ignored_modules=("xml.etree*",)) def test_ignored_modules_patterns(self) -> None: node = astroid.extract_node( diff --git a/tests/functional/n/no/no_member_imports.py b/tests/functional/n/no/no_member_imports.py index 1c4f9b3096..b82d42761d 100644 --- a/tests/functional/n/no/no_member_imports.py +++ b/tests/functional/n/no/no_member_imports.py @@ -22,3 +22,10 @@ def test_ignored_modules_invalid_pattern() -> None: import xml xml.etree.Lala # [no-member] + + +def test_ignored_modules_root_one_applies_as_well() -> None: + """Check that when a root module is completely ignored, submodules are skipped.""" + import argparse + + argparse.submodule.Lala From 255562a18562804ac85b8913771aa188a8a3cc32 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Dani=C3=ABl=20van=20Noord?= <13665637+DanielNoord@users.noreply.github.com> Date: Thu, 2 Dec 2021 17:03:30 +0100 Subject: [PATCH 05/11] Move test --- tests/checkers/unittest_typecheck.py | 11 ----------- tests/functional/n/no/no_member_imports.py | 10 ++++++++-- tests/functional/n/no/no_member_imports.rc | 2 +- tests/functional/n/no/no_member_imports.txt | 2 +- 4 files changed, 10 insertions(+), 15 deletions(-) diff --git a/tests/checkers/unittest_typecheck.py b/tests/checkers/unittest_typecheck.py index 85c0b9f7b9..0a6e9df3e3 100644 --- a/tests/checkers/unittest_typecheck.py +++ b/tests/checkers/unittest_typecheck.py @@ -49,17 +49,6 @@ class TestTypeChecker(CheckerTestCase): "Tests for pylint.checkers.typecheck" CHECKER_CLASS = typecheck.TypeChecker - @set_config(ignored_modules=("xml.etree*",)) - def test_ignored_modules_patterns(self) -> None: - node = astroid.extract_node( - """ - import xml - xml.etree.portocola #@ - """ - ) - with self.assertNoMessages(): - self.checker.visit_attribute(node) - @set_config(ignored_classes=("xml.*",)) def test_ignored_classes_no_recursive_pattern(self) -> None: node = astroid.extract_node( diff --git a/tests/functional/n/no/no_member_imports.py b/tests/functional/n/no/no_member_imports.py index b82d42761d..13fc260fe1 100644 --- a/tests/functional/n/no/no_member_imports.py +++ b/tests/functional/n/no/no_member_imports.py @@ -21,11 +21,17 @@ def test_no_member_in_getattr_ignored() -> None: def test_ignored_modules_invalid_pattern() -> None: import xml - xml.etree.Lala # [no-member] + xml.etree.THIS_does_not_EXIST # [no-member] def test_ignored_modules_root_one_applies_as_well() -> None: """Check that when a root module is completely ignored, submodules are skipped.""" import argparse - argparse.submodule.Lala + argparse.submodule.THIS_does_not_EXIST + + +def test_ignored_modules_patterns() -> None: + import collections + + collections.abc.THIS_does_not_EXIST diff --git a/tests/functional/n/no/no_member_imports.rc b/tests/functional/n/no/no_member_imports.rc index ecf110b1cb..eb7f2a20c0 100644 --- a/tests/functional/n/no/no_member_imports.rc +++ b/tests/functional/n/no/no_member_imports.rc @@ -1,2 +1,2 @@ [TYPECHECK] -ignored-modules=argparse,xml.etree. +ignored-modules=argparse,xml.etree.,collections.abc* diff --git a/tests/functional/n/no/no_member_imports.txt b/tests/functional/n/no/no_member_imports.txt index 48b8c021ee..6784c4e772 100644 --- a/tests/functional/n/no/no_member_imports.txt +++ b/tests/functional/n/no/no_member_imports.txt @@ -1,2 +1,2 @@ no-member:9:4:9:35:test_no_member_in_getattr:Module 'collections' has no 'THIS_does_not_EXIST' member:INFERENCE -no-member:24:4:24:18:test_ignored_modules_invalid_pattern:Module 'xml.etree' has no 'Lala' member:INFERENCE +no-member:24:4:24:33:test_ignored_modules_invalid_pattern:Module 'xml.etree' has no 'THIS_does_not_EXIST' member:INFERENCE From edad7257588d035e47365ff8bca998be580afdd9 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Dani=C3=ABl=20van=20Noord?= <13665637+DanielNoord@users.noreply.github.com> Date: Thu, 2 Dec 2021 17:05:29 +0100 Subject: [PATCH 06/11] Move test --- tests/checkers/unittest_typecheck.py | 17 ----------------- tests/functional/n/no/no_member_imports.py | 4 ++++ tests/functional/n/no/no_member_imports.rc | 1 + tests/functional/n/no/no_member_imports.txt | 1 + 4 files changed, 6 insertions(+), 17 deletions(-) diff --git a/tests/checkers/unittest_typecheck.py b/tests/checkers/unittest_typecheck.py index 0a6e9df3e3..faf334e9a5 100644 --- a/tests/checkers/unittest_typecheck.py +++ b/tests/checkers/unittest_typecheck.py @@ -49,23 +49,6 @@ class TestTypeChecker(CheckerTestCase): "Tests for pylint.checkers.typecheck" CHECKER_CLASS = typecheck.TypeChecker - @set_config(ignored_classes=("xml.*",)) - def test_ignored_classes_no_recursive_pattern(self) -> None: - node = astroid.extract_node( - """ - import xml - xml.etree.ElementTree.Test - """ - ) - message = MessageTest( - "no-member", - node=node, - args=("Module", "xml.etree.ElementTree", "Test", ""), - confidence=INFERENCE, - ) - with self.assertAddsMessages(message): - self.checker.visit_attribute(node) - @set_config(ignored_classes=("optparse.Values",)) def test_ignored_classes_qualified_name(self) -> None: """Test that ignored-classes supports qualified name for ignoring.""" diff --git a/tests/functional/n/no/no_member_imports.py b/tests/functional/n/no/no_member_imports.py index 13fc260fe1..35b8f8c338 100644 --- a/tests/functional/n/no/no_member_imports.py +++ b/tests/functional/n/no/no_member_imports.py @@ -35,3 +35,7 @@ def test_ignored_modules_patterns() -> None: import collections collections.abc.THIS_does_not_EXIST + +def test_ignored_classes_no_recursive_pattern() -> None: + import dataclasses + dataclasses.THIS_does_not_EXIST # [no-member] diff --git a/tests/functional/n/no/no_member_imports.rc b/tests/functional/n/no/no_member_imports.rc index eb7f2a20c0..f789e53e27 100644 --- a/tests/functional/n/no/no_member_imports.rc +++ b/tests/functional/n/no/no_member_imports.rc @@ -1,2 +1,3 @@ [TYPECHECK] ignored-modules=argparse,xml.etree.,collections.abc* +ignored-classes=dataclasses* diff --git a/tests/functional/n/no/no_member_imports.txt b/tests/functional/n/no/no_member_imports.txt index 6784c4e772..a1d6f82c68 100644 --- a/tests/functional/n/no/no_member_imports.txt +++ b/tests/functional/n/no/no_member_imports.txt @@ -1,2 +1,3 @@ no-member:9:4:9:35:test_no_member_in_getattr:Module 'collections' has no 'THIS_does_not_EXIST' member:INFERENCE no-member:24:4:24:33:test_ignored_modules_invalid_pattern:Module 'xml.etree' has no 'THIS_does_not_EXIST' member:INFERENCE +no-member:41:4:41:35:test_ignored_classes_no_recursive_pattern:Module 'dataclasses' has no 'THIS_does_not_EXIST' member:INFERENCE From 0966dd34e0e96300d3debcd64b49a16b5de1cbc9 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Dani=C3=ABl=20van=20Noord?= <13665637+DanielNoord@users.noreply.github.com> Date: Thu, 2 Dec 2021 17:06:53 +0100 Subject: [PATCH 07/11] Move test --- tests/checkers/unittest_typecheck.py | 12 ------------ tests/functional/n/no/no_member_imports.py | 13 ++++++++++++- tests/functional/n/no/no_member_imports.rc | 2 +- tests/functional/n/no/no_member_imports.txt | 6 +++--- 4 files changed, 16 insertions(+), 17 deletions(-) diff --git a/tests/checkers/unittest_typecheck.py b/tests/checkers/unittest_typecheck.py index faf334e9a5..d7ed1b7785 100644 --- a/tests/checkers/unittest_typecheck.py +++ b/tests/checkers/unittest_typecheck.py @@ -49,18 +49,6 @@ class TestTypeChecker(CheckerTestCase): "Tests for pylint.checkers.typecheck" CHECKER_CLASS = typecheck.TypeChecker - @set_config(ignored_classes=("optparse.Values",)) - def test_ignored_classes_qualified_name(self) -> None: - """Test that ignored-classes supports qualified name for ignoring.""" - node = astroid.extract_node( - """ - import optparse - optparse.Values.lala - """ - ) - with self.assertNoMessages(): - self.checker.visit_attribute(node) - @set_config(ignored_classes=("Values",)) def test_ignored_classes_only_name(self) -> None: """Test that ignored_classes works with the name only.""" diff --git a/tests/functional/n/no/no_member_imports.py b/tests/functional/n/no/no_member_imports.py index 35b8f8c338..850b50406c 100644 --- a/tests/functional/n/no/no_member_imports.py +++ b/tests/functional/n/no/no_member_imports.py @@ -1,5 +1,6 @@ """Tests for no-member on imported modules""" # pylint: disable=import-outside-toplevel, pointless-statement, missing-function-docstring +# pylint: disable=deprecated-module def test_no_member_in_getattr(): @@ -36,6 +37,16 @@ def test_ignored_modules_patterns() -> None: collections.abc.THIS_does_not_EXIST + def test_ignored_classes_no_recursive_pattern() -> None: import dataclasses - dataclasses.THIS_does_not_EXIST # [no-member] + + dataclasses.THIS_does_not_EXIST # [no-member] + + +def test_ignored_classes_qualified_name() -> None: + """Test that ignored-classes supports qualified name for ignoring.""" + + import optparse + + optparse.Values.lala diff --git a/tests/functional/n/no/no_member_imports.rc b/tests/functional/n/no/no_member_imports.rc index f789e53e27..fbcc61b9c2 100644 --- a/tests/functional/n/no/no_member_imports.rc +++ b/tests/functional/n/no/no_member_imports.rc @@ -1,3 +1,3 @@ [TYPECHECK] ignored-modules=argparse,xml.etree.,collections.abc* -ignored-classes=dataclasses* +ignored-classes=dataclasses*,optparse.Values diff --git a/tests/functional/n/no/no_member_imports.txt b/tests/functional/n/no/no_member_imports.txt index a1d6f82c68..7774bba2e0 100644 --- a/tests/functional/n/no/no_member_imports.txt +++ b/tests/functional/n/no/no_member_imports.txt @@ -1,3 +1,3 @@ -no-member:9:4:9:35:test_no_member_in_getattr:Module 'collections' has no 'THIS_does_not_EXIST' member:INFERENCE -no-member:24:4:24:33:test_ignored_modules_invalid_pattern:Module 'xml.etree' has no 'THIS_does_not_EXIST' member:INFERENCE -no-member:41:4:41:35:test_ignored_classes_no_recursive_pattern:Module 'dataclasses' has no 'THIS_does_not_EXIST' member:INFERENCE +no-member:10:4:10:35:test_no_member_in_getattr:Module 'collections' has no 'THIS_does_not_EXIST' member:INFERENCE +no-member:25:4:25:33:test_ignored_modules_invalid_pattern:Module 'xml.etree' has no 'THIS_does_not_EXIST' member:INFERENCE +no-member:44:4:44:35:test_ignored_classes_no_recursive_pattern:Module 'dataclasses' has no 'THIS_does_not_EXIST' member:INFERENCE From 54eaa52bb93dc1d910e8876f463cf71d84193ae5 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Dani=C3=ABl=20van=20Noord?= <13665637+DanielNoord@users.noreply.github.com> Date: Thu, 2 Dec 2021 17:16:27 +0100 Subject: [PATCH 08/11] Move test --- tests/checkers/unittest_typecheck.py | 12 ------------ tests/functional/n/no/no_member_imports.py | 9 ++++++++- tests/functional/n/no/no_member_imports.rc | 2 +- 3 files changed, 9 insertions(+), 14 deletions(-) diff --git a/tests/checkers/unittest_typecheck.py b/tests/checkers/unittest_typecheck.py index d7ed1b7785..6b944b9b80 100644 --- a/tests/checkers/unittest_typecheck.py +++ b/tests/checkers/unittest_typecheck.py @@ -49,18 +49,6 @@ class TestTypeChecker(CheckerTestCase): "Tests for pylint.checkers.typecheck" CHECKER_CLASS = typecheck.TypeChecker - @set_config(ignored_classes=("Values",)) - def test_ignored_classes_only_name(self) -> None: - """Test that ignored_classes works with the name only.""" - node = astroid.extract_node( - """ - import optparse - optparse.Values.lala - """ - ) - with self.assertNoMessages(): - self.checker.visit_attribute(node) - @set_config(suggestion_mode=False) @needs_c_extension def test_nomember_on_c_extension_error_msg(self) -> None: diff --git a/tests/functional/n/no/no_member_imports.py b/tests/functional/n/no/no_member_imports.py index 850b50406c..9af7965221 100644 --- a/tests/functional/n/no/no_member_imports.py +++ b/tests/functional/n/no/no_member_imports.py @@ -49,4 +49,11 @@ def test_ignored_classes_qualified_name() -> None: import optparse - optparse.Values.lala + optparse.Values.THIS_does_not_EXIST + + +def test_ignored_classes_only_name() -> None: + """Test that ignored_classes works with the name only.""" + import optparse + + optparse.Option.THIS_does_not_EXIST diff --git a/tests/functional/n/no/no_member_imports.rc b/tests/functional/n/no/no_member_imports.rc index fbcc61b9c2..f32f8314a0 100644 --- a/tests/functional/n/no/no_member_imports.rc +++ b/tests/functional/n/no/no_member_imports.rc @@ -1,3 +1,3 @@ [TYPECHECK] ignored-modules=argparse,xml.etree.,collections.abc* -ignored-classes=dataclasses*,optparse.Values +ignored-classes=dataclasses*,optparse.Values,Option From e4b23c1ce829b08563d2e6d151b8812b8749da1c Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Dani=C3=ABl=20van=20Noord?= <13665637+DanielNoord@users.noreply.github.com> Date: Thu, 2 Dec 2021 17:51:55 +0100 Subject: [PATCH 09/11] Do not use collecitons for check --- tests/functional/n/no/no_member_imports.py | 4 ++-- tests/functional/n/no/no_member_imports.txt | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/tests/functional/n/no/no_member_imports.py b/tests/functional/n/no/no_member_imports.py index 9af7965221..73f00345f0 100644 --- a/tests/functional/n/no/no_member_imports.py +++ b/tests/functional/n/no/no_member_imports.py @@ -5,9 +5,9 @@ def test_no_member_in_getattr(): """Make sure that a module attribute access is checked by pylint.""" - import collections + import math - collections.THIS_does_not_EXIST # [no-member] + math.THIS_does_not_EXIST # [no-member] def test_no_member_in_getattr_ignored() -> None: diff --git a/tests/functional/n/no/no_member_imports.txt b/tests/functional/n/no/no_member_imports.txt index 7774bba2e0..553ce60902 100644 --- a/tests/functional/n/no/no_member_imports.txt +++ b/tests/functional/n/no/no_member_imports.txt @@ -1,3 +1,3 @@ -no-member:10:4:10:35:test_no_member_in_getattr:Module 'collections' has no 'THIS_does_not_EXIST' member:INFERENCE +no-member:10:4:10:28:test_no_member_in_getattr:Module 'math' has no 'THIS_does_not_EXIST' member:INFERENCE no-member:25:4:25:33:test_ignored_modules_invalid_pattern:Module 'xml.etree' has no 'THIS_does_not_EXIST' member:INFERENCE no-member:44:4:44:35:test_ignored_classes_no_recursive_pattern:Module 'dataclasses' has no 'THIS_does_not_EXIST' member:INFERENCE From b6814f62299f7ed2fbe00f49d7a48fdfb6038a9c Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Dani=C3=ABl=20van=20Noord?= <13665637+DanielNoord@users.noreply.github.com> Date: Thu, 2 Dec 2021 18:02:22 +0100 Subject: [PATCH 10/11] Do not use dataclasses as well :') --- tests/functional/n/no/no_member_imports.py | 4 ++-- tests/functional/n/no/no_member_imports.rc | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/tests/functional/n/no/no_member_imports.py b/tests/functional/n/no/no_member_imports.py index 73f00345f0..ead6d93352 100644 --- a/tests/functional/n/no/no_member_imports.py +++ b/tests/functional/n/no/no_member_imports.py @@ -39,9 +39,9 @@ def test_ignored_modules_patterns() -> None: def test_ignored_classes_no_recursive_pattern() -> None: - import dataclasses + import sys - dataclasses.THIS_does_not_EXIST # [no-member] + sys.THIS_does_not_EXIST # [no-member] def test_ignored_classes_qualified_name() -> None: diff --git a/tests/functional/n/no/no_member_imports.rc b/tests/functional/n/no/no_member_imports.rc index f32f8314a0..59db427c27 100644 --- a/tests/functional/n/no/no_member_imports.rc +++ b/tests/functional/n/no/no_member_imports.rc @@ -1,3 +1,3 @@ [TYPECHECK] ignored-modules=argparse,xml.etree.,collections.abc* -ignored-classes=dataclasses*,optparse.Values,Option +ignored-classes=sys*,optparse.Values,Option From 15993f646faef0703d328eac7cf9ded528a4ee31 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Dani=C3=ABl=20van=20Noord?= <13665637+DanielNoord@users.noreply.github.com> Date: Thu, 2 Dec 2021 18:02:46 +0100 Subject: [PATCH 11/11] Update functional test output --- tests/functional/n/no/no_member_imports.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/functional/n/no/no_member_imports.txt b/tests/functional/n/no/no_member_imports.txt index 553ce60902..477558597c 100644 --- a/tests/functional/n/no/no_member_imports.txt +++ b/tests/functional/n/no/no_member_imports.txt @@ -1,3 +1,3 @@ no-member:10:4:10:28:test_no_member_in_getattr:Module 'math' has no 'THIS_does_not_EXIST' member:INFERENCE no-member:25:4:25:33:test_ignored_modules_invalid_pattern:Module 'xml.etree' has no 'THIS_does_not_EXIST' member:INFERENCE -no-member:44:4:44:35:test_ignored_classes_no_recursive_pattern:Module 'dataclasses' has no 'THIS_does_not_EXIST' member:INFERENCE +no-member:44:4:44:27:test_ignored_classes_no_recursive_pattern:Module 'sys' has no 'THIS_does_not_EXIST' member:INFERENCE