Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing timeout for requests.Session object? #9517

Open
fossilet opened this issue Mar 22, 2024 · 1 comment
Open

Missing timeout for requests.Session object? #9517

fossilet opened this issue Mar 22, 2024 · 1 comment
Labels
False Negative 🦋 No message is emitted but something is wrong with the code Needs PR This issue is accepted, sufficiently specified and now needs an implementation
Milestone
3.3.0

Comments

@fossilet
Copy link

Question

missing-timeout / W3101 reports in my codebase requests.get calls, but not for:

session = requests.Session()
session.get(url)

Is it possible to make pylint also warn about these cases?

Documentation for future user

in code and docs.

Additional context

No response
@fossilet fossilet added Documentation 📗 Needs triage 📥 Just created, needs acknowledgment, triage, and proper labelling Question labels Mar 22, 2024
@Pierre-Sassoulas Pierre-Sassoulas added False Negative 🦋 No message is emitted but something is wrong with the code Needs PR This issue is accepted, sufficiently specified and now needs an implementation and removed Question Documentation 📗 Needs triage 📥 Just created, needs acknowledgment, triage, and proper labelling labels Mar 22, 2024
@joel6948 joel6948 mentioned this issue Apr 1, 2024
Closed
@joel6948
Copy link

joel6948 commented Apr 1, 2024

#9525 (comment)

i have added which may help in solving it
please let me know issues regarding it

use the command below for checks
pylint --load-plugins=pylint_plugins.requests_timeout_plugin your_code.py

@joel6948 joel6948 mentioned this issue Apr 1, 2024
Open
@Pierre-Sassoulas Pierre-Sassoulas added this to the 3.2.0 milestone Apr 1, 2024
@jacobtylerwalls jacobtylerwalls modified the milestones: 3.2.0, 3.3.0 May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
False Negative 🦋 No message is emitted but something is wrong with the code Needs PR This issue is accepted, sufficiently specified and now needs an implementation
Projects
None yet
Milestone
3.3.0
Development

No branches or pull requests
4 participants
@fossilet @Pierre-Sassoulas @jacobtylerwalls @joel6948