Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

--recursive=y ignores ignore-paths #6964

Closed
Avasam opened this issue Jun 16, 2022 · 7 comments · Fixed by #7080
Closed

--recursive=y ignores ignore-paths #6964

Avasam opened this issue Jun 16, 2022 · 7 comments · Fixed by #7080
Labels
Bug 🪲 Configuration Related to configuration
Milestone

Comments

@Avasam
Copy link

Avasam commented Jun 16, 2022

Bug description

When running recursively, it seems ignore-paths in my settings in pyproject.toml is completely ignored

Configuration

[tool.pylint.MASTER]
ignore-paths = [
  # Auto generated
  "^src/gen/.*$",
]

Command used

pylint --recursive=y src/

Pylint output

************* Module region_selection
src\region_selection.py:170:0: R0914: Too many local variables (17/15) (too-many-locals)
************* Module about
src\gen\about.py:2:0: R2044: Line with empty comment (empty-comment)
src\gen\about.py:4:0: R2044: Line with empty comment (empty-comment)
src\gen\about.py:57:0: C0301: Line too long (504/120) (line-too-long)
src\gen\about.py:12:0: C0103: Class name "Ui_AboutAutoSplitWidget" doesn't conform to '_?_?[a-zA-Z]+?$' pattern (invalid-name)
src\gen\about.py:12:0: R0205: Class 'Ui_AboutAutoSplitWidget' inherits from object, can be safely removed from bases in python3 (useless-object-inheritance)
src\gen\about.py:13:4: C0103: Method name "setupUi" doesn't conform to snake_case naming style (invalid-name)
src\gen\about.py:13:22: C0103: Argument name "AboutAutoSplitWidget" doesn't conform to snake_case naming style (invalid-name)
src\gen\about.py:53:4: C0103: Method name "retranslateUi" doesn't conform to snake_case naming style (invalid-name)
src\gen\about.py:53:28: C0103: Argument name "AboutAutoSplitWidget" doesn't conform to snake_case naming style (invalid-name)
src\gen\about.py:24:8: W0201: Attribute 'ok_button' defined outside __init__ (attribute-defined-outside-init)
src\gen\about.py:27:8: W0201: Attribute 'created_by_label' defined outside __init__ (attribute-defined-outside-init)
src\gen\about.py:30:8: W0201: Attribute 'version_label' defined outside __init__ (attribute-defined-outside-init)
src\gen\about.py:33:8: W0201: Attribute 'donate_text_label' defined outside __init__ (attribute-defined-outside-init)
src\gen\about.py:37:8: W0201: Attribute 'donate_button_label' defined outside __init__ (attribute-defined-outside-init)
src\gen\about.py:43:8: W0201: Attribute 'icon_label' defined outside __init__ (attribute-defined-outside-init)
************* Module design
src\gen\design.py:2:0: R2044: Line with empty comment (empty-comment)
src\gen\design.py:4:0: R2044: Line with empty comment (empty-comment)
src\gen\design.py:328:0: C0301: Line too long (123/120) (line-too-long)
src\gen\design.py:363:0: C0301: Line too long (125/120) (line-too-long)
src\gen\design.py:373:0: C0301: Line too long (121/120) (line-too-long)
src\gen\design.py:412:0: C0301: Line too long (131/120) (line-too-long)
src\gen\design.py:12:0: C0103: Class name "Ui_MainWindow" doesn't conform to '_?_?[a-zA-Z]+?$' pattern (invalid-name)
src\gen\design.py:308:8: C0103: Attribute name "actionSplit_Settings" doesn't conform to snake_case naming style (invalid-name)
src\gen\design.py:318:8: C0103: Attribute name "actionCheck_for_Updates_on_Open" doesn't conform to snake_case naming style (invalid-name)
src\gen\design.py:323:8: C0103: Attribute name "actionLoop_Last_Split_Image_To_First_Image" doesn't conform to snake_case naming style (invalid-name)
src\gen\design.py:325:8: C0103: Attribute name "actionAuto_Start_On_Reset" doesn't conform to snake_case naming style (invalid-name)
src\gen\design.py:327:8: C0103: Attribute name "actionGroup_dummy_splits_when_undoing_skipping" doesn't conform to snake_case naming style (invalid-name)
src\gen\design.py:12:0: R0205: Class 'Ui_MainWindow' inherits from object, can be safely removed from bases in python3 (useless-object-inheritance)
src\gen\design.py:12:0: R0902: Too many instance attributes (69/15) (too-many-instance-attributes)
src\gen\design.py:13:4: C0103: Method name "setupUi" doesn't conform to snake_case naming style (invalid-name)
src\gen\design.py:13:22: C0103: Argument name "MainWindow" doesn't conform to snake_case naming style (invalid-name)
src\gen\design.py:16:8: C0103: Variable name "sizePolicy" doesn't conform to snake_case naming style (invalid-name)
src\gen\design.py:13:4: R0915: Too many statements (339/50) (too-many-statements)
src\gen\design.py:354:4: C0103: Method name "retranslateUi" doesn't conform to snake_case naming style (invalid-name)
src\gen\design.py:354:28: C0103: Argument name "MainWindow" doesn't conform to snake_case naming style (invalid-name)
src\gen\design.py:354:4: R0915: Too many statements (61/50) (too-many-statements)
src\gen\design.py:31:8: W0201: Attribute 'central_widget' defined outside __init__ (attribute-defined-outside-init)
src\gen\design.py:33:8: W0201: Attribute 'x_label' defined outside __init__ (attribute-defined-outside-init)
src\gen\design.py:36:8: W0201: Attribute 'select_region_button' defined outside __init__ (attribute-defined-outside-init)
src\gen\design.py:40:8: W0201: Attribute 'start_auto_splitter_button' defined outside __init__ (attribute-defined-outside-init)
src\gen\design.py:44:8: W0201: Attribute 'reset_button' defined outside __init__ (attribute-defined-outside-init)
src\gen\design.py:49:8: W0201: Attribute 'undo_split_button' defined outside __init__ (attribute-defined-outside-init)
src\gen\design.py:54:8: W0201: Attribute 'skip_split_button' defined outside __init__ (attribute-defined-outside-init)
src\gen\design.py:59:8: W0201: Attribute 'check_fps_button' defined outside __init__ (attribute-defined-outside-init)
src\gen\design.py:63:8: W0201: Attribute 'fps_label' defined outside __init__ (attribute-defined-outside-init)
src\gen\design.py:66:8: W0201: Attribute 'live_image' defined outside __init__ (attribute-defined-outside-init)
src\gen\design.py:75:8: W0201: Attribute 'current_split_image' defined outside __init__ (attribute-defined-outside-init)
src\gen\design.py:81:8: W0201: Attribute 'current_image_label' defined outside __init__ (attribute-defined-outside-init)
src\gen\design.py:85:8: W0201: Attribute 'width_label' defined outside __init__ (attribute-defined-outside-init)
src\gen\design.py:88:8: W0201: Attribute 'height_label' defined outside __init__ (attribute-defined-outside-init)
src\gen\design.py:91:8: W0201: Attribute 'fps_value_label' defined outside __init__ (attribute-defined-outside-init)
src\gen\design.py:95:8: W0201: Attribute 'width_spinbox' defined outside __init__ (attribute-defined-outside-init)
src\gen\design.py:101:8: W0201: Attribute 'height_spinbox' defined outside __init__ (attribute-defined-outside-init)
src\gen\design.py:107:8: W0201: Attribute 'capture_region_label' defined outside __init__ (attribute-defined-outside-init)
src\gen\design.py:111:8: W0201: Attribute 'current_image_file_label' defined outside __init__ (attribute-defined-outside-init)
src\gen\design.py:115:8: W0201: Attribute 'take_screenshot_button' defined outside __init__ (attribute-defined-outside-init)
src\gen\design.py:119:8: W0201: Attribute 'x_spinbox' defined outside __init__ (attribute-defined-outside-init)
src\gen\design.py:128:8: W0201: Attribute 'y_spinbox' defined outside __init__ (attribute-defined-outside-init)
src\gen\design.py:136:8: W0201: Attribute 'y_label' defined outside __init__ (attribute-defined-outside-init)
src\gen\design.py:139:8: W0201: Attribute 'align_region_button' defined outside __init__ (attribute-defined-outside-init)
src\gen\design.py:143:8: W0201: Attribute 'select_window_button' defined outside __init__ (attribute-defined-outside-init)
src\gen\design.py:147:8: W0201: Attribute 'browse_button' defined outside __init__ (attribute-defined-outside-init)
src\gen\design.py:151:8: W0201: Attribute 'split_image_folder_label' defined outside __init__ (attribute-defined-outside-init)
src\gen\design.py:154:8: W0201: Attribute 'split_image_folder_input' defined outside __init__ (attribute-defined-outside-init)
src\gen\design.py:158:8: W0201: Attribute 'capture_region_window_label' defined outside __init__ (attribute-defined-outside-init)
src\gen\design.py:162:8: W0201: Attribute 'image_loop_label' defined outside __init__ (attribute-defined-outside-init)
src\gen\design.py:165:8: W0201: Attribute 'similarity_viewer_groupbox' defined outside __init__ (attribute-defined-outside-init)
src\gen\design.py:169:8: W0201: Attribute 'table_live_label' defined outside __init__ (attribute-defined-outside-init)
src\gen\design.py:173:8: W0201: Attribute 'table_highest_label' defined outside __init__ (attribute-defined-outside-init)
src\gen\design.py:177:8: W0201: Attribute 'table_threshold_label' defined outside __init__ (attribute-defined-outside-init)
src\gen\design.py:181:8: W0201: Attribute 'line_1' defined outside __init__ (attribute-defined-outside-init)
src\gen\design.py:186:8: W0201: Attribute 'table_current_image_label' defined outside __init__ (attribute-defined-outside-init)
src\gen\design.py:189:8: W0201: Attribute 'table_reset_image_label' defined outside __init__ (attribute-defined-outside-init)
src\gen\design.py:192:8: W0201: Attribute 'line_2' defined outside __init__ (attribute-defined-outside-init)
src\gen\design.py:197:8: W0201: Attribute 'line_3' defined outside __init__ (attribute-defined-outside-init)
src\gen\design.py:202:8: W0201: Attribute 'line_4' defined outside __init__ (attribute-defined-outside-init)
src\gen\design.py:207:8: W0201: Attribute 'line_5' defined outside __init__ (attribute-defined-outside-init)
src\gen\design.py:212:8: W0201: Attribute 'table_current_image_live_label' defined outside __init__ (attribute-defined-outside-init)
src\gen\design.py:216:8: W0201: Attribute 'table_current_image_highest_label' defined outside __init__ (attribute-defined-outside-init)
src\gen\design.py:220:8: W0201: Attribute 'table_current_image_threshold_label' defined outside __init__ (attribute-defined-outside-init)
src\gen\design.py:224:8: W0201: Attribute 'table_reset_image_live_label' defined outside __init__ (attribute-defined-outside-init)
src\gen\design.py:228:8: W0201: Attribute 'table_reset_image_highest_label' defined outside __init__ (attribute-defined-outside-init)
src\gen\design.py:232:8: W0201: Attribute 'table_reset_image_threshold_label' defined outside __init__ (attribute-defined-outside-init)
src\gen\design.py:236:8: W0201: Attribute 'reload_start_image_button' defined outside __init__ (attribute-defined-outside-init)
src\gen\design.py:240:8: W0201: Attribute 'start_image_status_label' defined outside __init__ (attribute-defined-outside-init)
src\gen\design.py:243:8: W0201: Attribute 'start_image_status_value_label' defined outside __init__ (attribute-defined-outside-init)
src\gen\design.py:246:8: W0201: Attribute 'image_loop_value_label' defined outside __init__ (attribute-defined-outside-init)
src\gen\design.py:249:8: W0201: Attribute 'previous_image_button' defined outside __init__ (attribute-defined-outside-init)
src\gen\design.py:254:8: W0201: Attribute 'next_image_button' defined outside __init__ (attribute-defined-outside-init)
src\gen\design.py:296:8: W0201: Attribute 'menu_bar' defined outside __init__ (attribute-defined-outside-init)
src\gen\design.py:299:8: W0201: Attribute 'menu_help' defined outside __init__ (attribute-defined-outside-init)
src\gen\design.py:301:8: W0201: Attribute 'menu_file' defined outside __init__ (attribute-defined-outside-init)
src\gen\design.py:304:8: W0201: Attribute 'action_view_help' defined outside __init__ (attribute-defined-outside-init)
src\gen\design.py:306:8: W0201: Attribute 'action_about' defined outside __init__ (attribute-defined-outside-init)
src\gen\design.py:308:8: W0201: Attribute 'actionSplit_Settings' defined outside __init__ (attribute-defined-outside-init)
src\gen\design.py:310:8: W0201: Attribute 'action_save_profile' defined outside __init__ (attribute-defined-outside-init)
src\gen\design.py:312:8: W0201: Attribute 'action_load_profile' defined outside __init__ (attribute-defined-outside-init)
src\gen\design.py:314:8: W0201: Attribute 'action_save_profile_as' defined outside __init__ (attribute-defined-outside-init)
src\gen\design.py:316:8: W0201: Attribute 'action_check_for_updates' defined outside __init__ (attribute-defined-outside-init)
src\gen\design.py:318:8: W0201: Attribute 'actionCheck_for_Updates_on_Open' defined outside __init__ (attribute-defined-outside-init)
src\gen\design.py:323:8: W0201: Attribute 'actionLoop_Last_Split_Image_To_First_Image' defined outside __init__ (attribute-defined-outside-init)
src\gen\design.py:325:8: W0201: Attribute 'actionAuto_Start_On_Reset' defined outside __init__ (attribute-defined-outside-init)
src\gen\design.py:327:8: W0201: Attribute 'actionGroup_dummy_splits_when_undoing_skipping' defined outside __init__ (attribute-defined-outside-init)
src\gen\design.py:329:8: W0201: Attribute 'action_settings' defined outside __init__ (attribute-defined-outside-init)
src\gen\design.py:331:8: W0201: Attribute 'action_check_for_updates_on_open' defined outside __init__ (attribute-defined-outside-init)
************* Module resources_rc
src\gen\resources_rc.py:1:0: C0302: Too many lines in module (2311/1000) (too-many-lines)
src\gen\resources_rc.py:8:0: C0103: Constant name "qt_resource_data" doesn't conform to UPPER_CASE naming style (invalid-name)
src\gen\resources_rc.py:2278:0: C0103: Constant name "qt_resource_name" doesn't conform to UPPER_CASE naming style (invalid-name)
src\gen\resources_rc.py:2294:0: C0103: Constant name "qt_resource_struct" doesn't conform to UPPER_CASE naming style (invalid-name)
src\gen\resources_rc.py:2305:0: C0103: Function name "qInitResources" doesn't conform to snake_case naming style (invalid-name)
src\gen\resources_rc.py:2308:0: C0103: Function name "qCleanupResources" doesn't conform to snake_case naming style (invalid-name)
************* Module settings
src\gen\settings.py:2:0: R2044: Line with empty comment (empty-comment)
src\gen\settings.py:4:0: R2044: Line with empty comment (empty-comment)
src\gen\settings.py:61:0: C0301: Line too long (158/120) (line-too-long)
src\gen\settings.py:123:0: C0301: Line too long (151/120) (line-too-long)
src\gen\settings.py:209:0: C0301: Line too long (162/120) (line-too-long)
src\gen\settings.py:214:0: C0301: Line too long (121/120) (line-too-long)
src\gen\settings.py:221:0: C0301: Line too long (177/120) (line-too-long)
src\gen\settings.py:223:0: C0301: Line too long (181/120) (line-too-long)
src\gen\settings.py:226:0: C0301: Line too long (461/120) (line-too-long)
src\gen\settings.py:228:0: C0301: Line too long (192/120) (line-too-long)
src\gen\settings.py:12:0: C0103: Class name "Ui_DialogSettings" doesn't conform to '_?_?[a-zA-Z]+?$' pattern (invalid-name)
src\gen\settings.py:12:0: R0205: Class 'Ui_DialogSettings' inherits from object, can be safely removed from bases in python3 (useless-object-inheritance)
src\gen\settings.py:12:0: R0902: Too many instance attributes (35/15) (too-many-instance-attributes)
src\gen\settings.py:13:4: C0103: Method name "setupUi" doesn't conform to snake_case naming style (invalid-name)
src\gen\settings.py:13:22: C0103: Argument name "DialogSettings" doesn't conform to snake_case naming style (invalid-name)
src\gen\settings.py:16:8: C0103: Variable name "sizePolicy" doesn't conform to snake_case naming style (invalid-name)
src\gen\settings.py:13:4: R0915: Too many statements (190/50) (too-many-statements)
src\gen\settings.py:205:4: C0103: Method name "retranslateUi" doesn't conform to snake_case naming style (invalid-name)
src\gen\settings.py:205:28: C0103: Argument name "DialogSettings" doesn't conform to snake_case naming style (invalid-name)
src\gen\settings.py:26:8: W0201: Attribute 'capture_settings_groupbox' defined outside __init__ (attribute-defined-outside-init)
src\gen\settings.py:29:8: W0201: Attribute 'fps_limit_spinbox' defined outside __init__ (attribute-defined-outside-init)
src\gen\settings.py:36:8: W0201: Attribute 'fps_limit_label' defined outside __init__ (attribute-defined-outside-init)
src\gen\settings.py:40:8: W0201: Attribute 'live_capture_region_checkbox' defined outside __init__ (attribute-defined-outside-init)
src\gen\settings.py:46:8: W0201: Attribute 'capture_method_combobox' defined outside __init__ (attribute-defined-outside-init)
src\gen\settings.py:49:8: W0201: Attribute 'capture_method_label' defined outside __init__ (attribute-defined-outside-init)
src\gen\settings.py:52:8: W0201: Attribute 'capture_device_label' defined outside __init__ (attribute-defined-outside-init)
src\gen\settings.py:55:8: W0201: Attribute 'capture_device_combobox' defined outside __init__ (attribute-defined-outside-init)
src\gen\settings.py:59:8: W0201: Attribute 'image_settings_groupbox' defined outside __init__ (attribute-defined-outside-init)
src\gen\settings.py:65:8: W0201: Attribute 'default_comparison_method' defined outside __init__ (attribute-defined-outside-init)
src\gen\settings.py:73:8: W0201: Attribute 'default_comparison_method_label' defined outside __init__ (attribute-defined-outside-init)
src\gen\settings.py:76:8: W0201: Attribute 'default_pause_time_label' defined outside __init__ (attribute-defined-outside-init)
src\gen\settings.py:80:8: W0201: Attribute 'default_pause_time_spinbox' defined outside __init__ (attribute-defined-outside-init)
src\gen\settings.py:87:8: W0201: Attribute 'default_similarity_threshold_label' defined outside __init__ (attribute-defined-outside-init)
src\gen\settings.py:92:8: W0201: Attribute 'default_similarity_threshold_spinbox' defined outside __init__ (attribute-defined-outside-init)
src\gen\settings.py:98:8: W0201: Attribute 'loop_splits_checkbox' defined outside __init__ (attribute-defined-outside-init)
src\gen\settings.py:104:8: W0201: Attribute 'custom_image_settings_info_label' defined outside __init__ (attribute-defined-outside-init)
src\gen\settings.py:111:8: W0201: Attribute 'default_delay_time_label' defined outside __init__ (attribute-defined-outside-init)
src\gen\settings.py:116:8: W0201: Attribute 'default_delay_time_spinbox' defined outside __init__ (attribute-defined-outside-init)
src\gen\settings.py:121:8: W0201: Attribute 'hotkeys_groupbox' defined outside __init__ (attribute-defined-outside-init)
src\gen\settings.py:127:8: W0201: Attribute 'set_pause_hotkey_button' defined outside __init__ (attribute-defined-outside-init)
src\gen\settings.py:131:8: W0201: Attribute 'split_input' defined outside __init__ (attribute-defined-outside-init)
src\gen\settings.py:137:8: W0201: Attribute 'undo_split_input' defined outside __init__ (attribute-defined-outside-init)
src\gen\settings.py:143:8: W0201: Attribute 'split_label' defined outside __init__ (attribute-defined-outside-init)
src\gen\settings.py:146:8: W0201: Attribute 'reset_input' defined outside __init__ (attribute-defined-outside-init)
src\gen\settings.py:152:8: W0201: Attribute 'set_undo_split_hotkey_button' defined outside __init__ (attribute-defined-outside-init)
src\gen\settings.py:156:8: W0201: Attribute 'reset_label' defined outside __init__ (attribute-defined-outside-init)
src\gen\settings.py:159:8: W0201: Attribute 'set_reset_hotkey_button' defined outside __init__ (attribute-defined-outside-init)
src\gen\settings.py:163:8: W0201: Attribute 'set_split_hotkey_button' defined outside __init__ (attribute-defined-outside-init)
src\gen\settings.py:167:8: W0201: Attribute 'pause_label' defined outside __init__ (attribute-defined-outside-init)
src\gen\settings.py:170:8: W0201: Attribute 'pause_input' defined outside __init__ (attribute-defined-outside-init)
src\gen\settings.py:176:8: W0201: Attribute 'undo_split_label' defined outside __init__ (attribute-defined-outside-init)
src\gen\settings.py:179:8: W0201: Attribute 'set_skip_split_hotkey_button' defined outside __init__ (attribute-defined-outside-init)
src\gen\settings.py:183:8: W0201: Attribute 'skip_split_label' defined outside __init__ (attribute-defined-outside-init)
src\gen\settings.py:186:8: W0201: Attribute 'skip_split_input' defined outside __init__ (attribute-defined-outside-init)
************* Module update_checker
src\gen\update_checker.py:2:0: R2044: Line with empty comment (empty-comment)
src\gen\update_checker.py:4:0: R2044: Line with empty comment (empty-comment)
src\gen\update_checker.py:12:0: C0103: Class name "Ui_UpdateChecker" doesn't conform to '_?_?[a-zA-Z]+?$' pattern (invalid-name)
src\gen\update_checker.py:12:0: R0205: Class 'Ui_UpdateChecker' inherits from object, can be safely removed from bases in python3 (useless-object-inheritance)
src\gen\update_checker.py:13:4: C0103: Method name "setupUi" doesn't conform to snake_case naming style (invalid-name)
src\gen\update_checker.py:13:22: C0103: Argument name "UpdateChecker" doesn't conform to snake_case naming style (invalid-name)
src\gen\update_checker.py:17:8: C0103: Variable name "sizePolicy" doesn't conform to snake_case naming style (invalid-name)
src\gen\update_checker.py:33:8: C0103: Variable name "sizePolicy" doesn't conform to snake_case naming style (invalid-name)
src\gen\update_checker.py:13:4: R0915: Too many statements (56/50) (too-many-statements)
src\gen\update_checker.py:71:4: C0103: Method name "retranslateUi" doesn't conform to snake_case naming style (invalid-name)
src\gen\update_checker.py:71:28: C0103: Argument name "UpdateChecker" doesn't conform to snake_case naming style (invalid-name)
src\gen\update_checker.py:31:8: W0201: Attribute 'update_status_label' defined outside __init__ (attribute-defined-outside-init)
src\gen\update_checker.py:39:8: W0201: Attribute 'current_version_label' defined outside __init__ (attribute-defined-outside-init)
src\gen\update_checker.py:42:8: W0201: Attribute 'latest_version_label' defined outside __init__ (attribute-defined-outside-init)
src\gen\update_checker.py:45:8: W0201: Attribute 'go_to_download_label' defined outside __init__ (attribute-defined-outside-init)
src\gen\update_checker.py:48:8: W0201: Attribute 'left_button' defined outside __init__ (attribute-defined-outside-init)
src\gen\update_checker.py:52:8: W0201: Attribute 'right_button' defined outside __init__ (attribute-defined-outside-init)
src\gen\update_checker.py:55:8: W0201: Attribute 'current_version_number_label' defined outside __init__ (attribute-defined-outside-init)
src\gen\update_checker.py:59:8: W0201: Attribute 'latest_version_number_label' defined outside __init__ (attribute-defined-outside-init)
src\gen\update_checker.py:63:8: W0201: Attribute 'do_not_ask_again_checkbox' defined outside __init__ (attribute-defined-outside-init)
src\gen\update_checker.py:1:0: R0401: Cyclic import (region_capture -> region_selection) (cyclic-import)
src\gen\update_checker.py:1:0: R0401: Cyclic import (error_messages -> user_profile -> region_capture -> region_selection) (cyclic-import)
src\gen\update_checker.py:1:0: R0401: Cyclic import (AutoSplitImage -> split_parser) (cyclic-import)
src\gen\update_checker.py:1:0: R0401: Cyclic import (AutoControlledWorker -> error_messages -> AutoSplit) (cyclic-import)
src\gen\update_checker.py:1:0: R0401: Cyclic import (AutoSplit -> user_profile -> region_capture -> region_selection -> error_messages) (cyclic-import)
src\gen\update_checker.py:1:0: R0401: Cyclic import (AutoSplitImage -> error_messages -> user_profile) (cyclic-import)
src\gen\update_checker.py:1:0: R0401: Cyclic import (AutoSplit -> menu_bar -> user_profile -> region_capture -> region_selection -> error_messages) (cyclic-import)
src\gen\update_checker.py:1:0: R0401: Cyclic import (AutoSplit -> region_selection -> error_messages) (cyclic-import)
src\gen\update_checker.py:1:0: R0401: Cyclic import (AutoSplit -> error_messages) (cyclic-import)
src\gen\update_checker.py:1:0: R0401: Cyclic import (error_messages -> user_profile -> region_selection) (cyclic-import)
src\gen\update_checker.py:1:0: R0401: Cyclic import (error_messages -> user_profile) (cyclic-import)
src\gen\update_checker.py:1:0: R0401: Cyclic import (AutoSplitImage -> split_parser -> error_messages -> user_profile) (cyclic-import)
src\gen\update_checker.py:1:0: R0401: Cyclic import (AutoSplit -> menu_bar -> region_selection -> error_messages) (cyclic-import)
src\gen\update_checker.py:1:0: R0401: Cyclic import (AutoSplit -> menu_bar -> error_messages) (cyclic-import)

--------------------------------------------------------------------------
Your code has been rated at -158.32/10 (previous run: -285.20/10, +126.88)

Expected behavior

src\gen* should not be checked

Pylint version

pylint 2.14.1
astroid 2.11.5
Python 3.9.6 (tags/v3.9.6:db3ff76, Jun 28 2021, 15:26:21) [MSC v.1929 64 bit (AMD64)]

OS / Environment

Windows 10.0.19044

Additional dependencies

No response

@Avasam Avasam added the Needs triage 📥 Just created, needs acknowledgment, triage, and proper labelling label Jun 16, 2022
@Pierre-Sassoulas Pierre-Sassoulas added Bug 🪲 pylint-config and removed Needs triage 📥 Just created, needs acknowledgment, triage, and proper labelling labels Jun 16, 2022
@DanielNoord DanielNoord added Configuration Related to configuration and removed pylint-config labels Jun 22, 2022
@DanielNoord
Copy link
Collaborator

@matusvalo Didn't you fix this recently? Or was this a case we overlooked?

#6528.

@matusvalo
Copy link
Collaborator

I will check

@matusvalo
Copy link
Collaborator

matusvalo commented Jun 22, 2022

I am not able to replicate the issue:

(pylint39) matusg@MacBook-Pro:~/dev/pylint/test$ cat src/gen/test.py
import bla
(pylint39) matusg@MacBook-Pro:~/dev/pylint/test$ pylint --version
pylint 2.14.1
astroid 2.11.6
Python 3.9.12 (main, May  8 2022, 18:05:13)
[Clang 12.0.0 (clang-1200.0.32.29)]
(pylint39) matusg@MacBook-Pro:~/dev/pylint/test$ cat pyproject.toml
[tool.pylint.MASTER]
ignore-paths = [
  # Auto generated
  "^src/gen/.*$",
]
(pylint39) matusg@MacBook-Pro:~/dev/pylint/test$ pylint --recursive=y src/
(pylint39) matusg@MacBook-Pro:~/dev/pylint/test$

I cannot verify the issue on windows.

NOTE: Commenting out "^src/gen/.*$", is yielding pylint errors in test.py file, so I consider that ignore-paths configuration is applied.

@matusvalo
Copy link
Collaborator

@Avasam could you provide simple reproducer for the issue?

@Avasam
Copy link
Author

Avasam commented Jun 22, 2022

@Avasam could you provide simple reproducer for the issue?

I too thought this was fixed by #6528. I'll try to come up with a simple repro. In the mean time, this is my project in question: https://github.com/Avasam/Auto-Split/tree/camera-capture-split-cam-option

@tbennett0
Copy link
Contributor

tbennett0 commented Jun 27, 2022

@matusvalo I think I've run into a similar (or possibly the same) issue. Trying to reproduce with your example:

% cat src/gen/test.py 
import bla

% pylint --version
pylint 2.13.9
astroid 2.11.5
Python 3.9.13 (main, May 24 2022, 21:28:31) 
[Clang 13.1.6 (clang-1316.0.21.2)]

% cat pyproject.toml 
[tool.pylint.MASTER]
ignore-paths = [
  # Auto generated
  "^src/gen/.*$", 
]


## Succeeds as expected                                                                                                                                                                                                                                                                           
% pylint --recursive=y src/

## Fails for some reason
% pylint --recursive=y .   
************* Module test
src/gen/test.py:1:0: C0114: Missing module docstring (missing-module-docstring)
src/gen/test.py:1:0: E0401: Unable to import 'bla' (import-error)
src/gen/test.py:1:0: W0611: Unused import bla (unused-import)

------------------------------------------------------------------

EDIT: Just upgraded to 2.14.3, and still seems to report the same.

@matusvalo
Copy link
Collaborator

Hmm I can reproduce your error, and now I understand the root cause. The root cause is following. The decision of skipping the path is here:

https://github.com/PyCQA/pylint/blob/3c5eca2ded3dd2b59ebaf23eb289453b5d2930f0/pylint/lint/pylinter.py#L600-L607

  • When you execute pylint with src/ argument following variables are present:
(Pdb) p root
'src/gen'
(Pdb) p self.config.ignore_paths
[re.compile('^src\\\\gen\\\\.*$|^src/gen/.*$')]
  • When you uexecute pylint with . argument following variables are present:
(Pdb) p root
'./src/gen'
(Pdb) p self.config.ignore_paths
[re.compile('^src\\\\gen\\\\.*$|^src/gen/.*$')]

In the second case, the source is prefixed with ./ which causes that path is not matched. The simple fix should be to use os.path.normpath() https://docs.python.org/3/library/os.path.html#os.path.normpath

@Pierre-Sassoulas Pierre-Sassoulas added this to the 2.14.4 milestone Jun 29, 2022
stanislavlevin added a commit to stanislavlevin/pyproject_installer that referenced this issue Jun 30, 2022
New pylint 2.14.4 includes fix for
pylint-dev/pylint#6964, this results in our pylint
configuration for `ignore-paths` is no longer valid (`./.tox` => `.tox`)
and pylint fails on checking not related projects from `.tox` directory:
> ERROR: InvocationError for command /home/runner/work/pyproject_installer/pyproject_installer/.tox/pylint/bin/python -m pylint -v --rcfile=/home/runner/work/pyproject_installer/pyproject_installer/pyproject.toml . (exited with code 30)

Fixes: #11
Signed-off-by: Stanislav Levin <slev@altlinux.org>
stanislavlevin added a commit to stanislavlevin/pyproject_installer that referenced this issue Jun 30, 2022
New pylint 2.14.4 includes fix for
pylint-dev/pylint#6964, this results in our pylint
configuration for `ignore-paths` is no longer valid (`./.tox` => `.tox`)
and pylint fails on checking not related projects from `.tox` directory:
> ERROR: InvocationError for command /home/runner/work/pyproject_installer/pyproject_installer/.tox/pylint/bin/python -m pylint -v --rcfile=/home/runner/work/pyproject_installer/pyproject_installer/pyproject.toml . (exited with code 30)

Fixes: #11
Signed-off-by: Stanislav Levin <slev@altlinux.org>
stanislavlevin added a commit to stanislavlevin/tox-console-scripts that referenced this issue Jun 30, 2022
New pylint 2.14.4 includes fix for
pylint-dev/pylint#6964, this results in our pylint
configuration for `ignore-paths` is no longer valid (`./.tox` => `.tox`)
and pylint fails on checking not related projects from `.tox` directory:

> ERROR: InvocationError for command /home/runner/work/tox-console-scripts/tox-console-scripts/.tox/pylint/bin/python -m pylint -v --rcfile=/home/runner/work/tox-console-scripts/tox-console-scripts/pyproject.toml . (exited with code 30)

Fixes: #20
Signed-off-by: Stanislav Levin <slev@altlinux.org>
stanislavlevin added a commit to stanislavlevin/tox-console-scripts that referenced this issue Jun 30, 2022
New pylint 2.14.4 includes fix for
pylint-dev/pylint#6964, this results in our pylint
configuration for `ignore-paths` is no longer valid (`./.tox` => `.tox`)
and pylint fails on checking not related projects from `.tox` directory:

> ERROR: InvocationError for command /home/runner/work/tox-console-scripts/tox-console-scripts/.tox/pylint/bin/python -m pylint -v --rcfile=/home/runner/work/tox-console-scripts/tox-console-scripts/pyproject.toml . (exited with code 30)

Fixes: #20
Signed-off-by: Stanislav Levin <slev@altlinux.org>
stanislavlevin added a commit to stanislavlevin/tox-no-deps that referenced this issue Jun 30, 2022
New pylint 2.14.4 includes fix for
pylint-dev/pylint#6964, this results in our pylint
configuration for `ignore-paths` is no longer valid (`./.tox` => `.tox`)
and pylint fails on checking not related projects from `.tox` directory:

> ERROR: InvocationError for command /home/runner/work/tox-no-deps/tox-no-deps/.tox/pylint/bin/python -m pylint -v --rcfile=/home/runner/work/tox-no-deps/tox-no-deps/pyproject.toml . (exited with code 30)

Fixes: #9
Signed-off-by: Stanislav Levin <slev@altlinux.org>
stanislavlevin added a commit to stanislavlevin/tox-no-deps that referenced this issue Jun 30, 2022
New pylint 2.14.4 includes fix for
pylint-dev/pylint#6964, this results in our pylint
configuration for `ignore-paths` is no longer valid (`./.tox` => `.tox`)
and pylint fails on checking not related projects from `.tox` directory:

> ERROR: InvocationError for command /home/runner/work/tox-no-deps/tox-no-deps/.tox/pylint/bin/python -m pylint -v --rcfile=/home/runner/work/tox-no-deps/tox-no-deps/pyproject.toml . (exited with code 30)

Fixes: #9
Signed-off-by: Stanislav Levin <slev@altlinux.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug 🪲 Configuration Related to configuration
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants