Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

More elaborate label check for when a changelog need to be added or not or automated generation of the changelog #6781

Closed
Pierre-Sassoulas opened this issue Jun 1, 2022 · 1 comment
Labels
Maintenance Discussion or action around maintaining pylint or the dev workflow Minor 馃拝 Polishing pylint is always nice
Milestone

Comments

@Pierre-Sassoulas
Copy link
Member

Pierre-Sassoulas commented Jun 1, 2022

Current problem

For 2.14 we're only checking the absence of the "skip news 馃攪" label.

Desired solution

There's some label that will rarely need to be documented though :
"documentation", "dependency", "primer" and "maintenance" should be exempted... except if they've been added to the current milestone. We need to handle the case when another label was applied. This can wait for after 2.14.0 release. Maybe "skip news 馃攪" is good enough indefinitely. We'd have to see how well it hold up with @DudeNr33 proposition to automatically generate the release notes too.

Additional context

#6632 (comment)
#6772 (review)
#6688 (comment)
#6688 (comment)

@Pierre-Sassoulas Pierre-Sassoulas added Minor 馃拝 Polishing pylint is always nice Maintenance Discussion or action around maintaining pylint or the dev workflow labels Jun 1, 2022
@Pierre-Sassoulas Pierre-Sassoulas added this to the 2.15.0 milestone Jun 1, 2022
@DanielNoord DanielNoord modified the milestones: 2.15.0, 2.16.0 Aug 23, 2022
@Pierre-Sassoulas
Copy link
Member Author

Closing as a maintainer deciding on a case by case basis using the skip-news label is good enough and even simpler so better.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Maintenance Discussion or action around maintaining pylint or the dev workflow Minor 馃拝 Polishing pylint is always nice
Projects
None yet
Development

No branches or pull requests

2 participants