-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PlantUML generation by pyreverse
may be incorrect
#6683
Comments
pyreverse
quatation may be incorrectpyreverse
may be incorrect
Thank you for reporting this issue. I'd also be interested in the structure of your package/directory, as the part after the Some more explanation about the placement of the quotes: Now, @startuml
class "Animal" as entities.Animal
class "Animal" as serializers.Animal
entities.Animal --> serializers.Animal
@enduml But that just as a side note, what you observed is definitely not the intended behaviour. |
Hi @DudeNr33, Thanks for your fast reply, very interesting! I have learned plenty of stuff from your explanations. There is still some mystery then why it didn't produce a valid PlantUML. So, to answer your questions and give some details:
After writing the part above, I have launched
This is the only arrow I have in the file (because there is no other inheritance in the project), but it fails. If I remove the first colon in this line, it does compile, but the arrow is not shown because the name does not correspond to a class defined above. Let me know if this helps you reproduce the problem? Will be happy to provide further information. |
Hi @Alexander-Serov, I tried to reproduce the issue with a similar setup (running Do you have any other repo/package which is not installed via pip where you could check if you also get paths instead of qualified names when running |
Hi @DudeNr33, Thanks for your reply and sorry for the delay. It took me some time to run tests. The weird thing is that I confirm your results. I was unable to produce the same quotation marks on the By the way, while testing on a third project, I found out that I was unable to launch Returning to the original problem, I am not sure how to investigate further. The issue is 100% reproducible on this package and our other one, but not on public packages. Perhaps, the namespace or the editable installation is a problem? Please let me know if you have any ideas. |
Maybe try installing the main branch of astroid, which has some improvements for namespace packages? At least something useful to rule out. |
@jacobtylerwalls Not sure if it is relevant here, but didn't we also see some differences between installing |
Bug description
Following PlantUML introduction in #4846, I have tried the following:
The resulting
classes.plantuml
file looks like this:which is kind of correct, but the quotation mark and the
as
should be the other way, I would say:The original version produced by
pyreverse
does not compile:While it compiles after the fix above.
Command used
Pylint output
Expected behavior
Qutation marks and
as
inversed: see bug description.Pylint version
OS / Environment
Win11
The text was updated successfully, but these errors were encountered: