Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New release for Python 3.9? #4055

Closed
juliangilbey opened this issue Feb 1, 2021 · 13 comments · Fixed by #4112
Closed

New release for Python 3.9? #4055

juliangilbey opened this issue Feb 1, 2021 · 13 comments · Fixed by #4112
Labels
Milestone

Comments

@juliangilbey
Copy link

At the moment, the latest pylint release (2.6.0) is hundreds of commits behind master; is there a plan to release a newer version in the near future?

Thanks for all your work on this!

@Pierre-Sassoulas
Copy link
Member

We're going to release in the near future, we need to merge pylint-dev/astroid#890 first, then all the pylint's approved merge request that are blocked by it.

@Pierre-Sassoulas
Copy link
Member

We released astroid 2.5, and started to merge the current approved merge request. We're going to continue doing that and also check what is causing #4093

@Pierre-Sassoulas
Copy link
Member

I cleared the MR log, but I think the main problem is the max recursion error that make pylint slow or even make it crash. Are you confident about the genuinely large recursion in the current version of astroid @hippo91 ? Seeing the discussion in #4106 (freeze in debian just started), we might want to release this week if we want to have a working pylint for python 3.9 in the latest debian.

@hippo91
Copy link
Contributor

hippo91 commented Feb 20, 2021

@Pierre-Sassoulas i noticed two kinds of problems. One deals with long execution time and seems to be linked to Generic types. The second deals with infinite recursion but seems to occur only when pandas object have to be inferred. Am i correct?

@Pierre-Sassoulas
Copy link
Member

I reached this conclusion too after checking (some of) the recursion issues and performance issues. Another thing to consider is that 2.6.0 suffer from the same problem, so maybe it's not a show stopper for releasing 2.7.0 ? Especially considering that astroid 2.5 got better for a lot of cases except pandas and 2.6.2 is not compatible with astroid 2.5 ?

@hippo91
Copy link
Contributor

hippo91 commented Feb 21, 2021

@Pierre-Sassoulas totally agree with you!

@Pierre-Sassoulas
Copy link
Member

Let's release 2.7.0 today then ? We'll then have 2 weeks to fix the crash and bugs that might appear so pylint can be packaged into debian 😄

@cdce8p
Copy link
Member

cdce8p commented Feb 21, 2021

Let's release 2.7.0 today then ? We'll then have 2 weeks to fix the crash and bugs that might appear so pylint can be packaged into debian 😄

Sounds good. Should we update the astroid dependency?

https://github.com/PyCQA/pylint/blob/34cce21d29f9692a34fec22a76bee70939e628a5/pylint/__pkginfo__.py#L43

I would suggest using ~=2.5 for pylint 2.7. That way we track the Bugfix branch of astroid.
Once it is released, we could update it again on the master branch to >2.5.0.

Should also update this here, to follow the 2.5 branch

https://github.com/PyCQA/pylint/blob/34cce21d29f9692a34fec22a76bee70939e628a5/requirements_test_pypy.txt#L1

I plan on updating the Github Action caching algorithm today to account for the different astroid branch. At the moment the cache key is always based of of master.

@cdce8p cdce8p mentioned this issue Feb 21, 2021
4 tasks
@cdce8p
Copy link
Member

cdce8p commented Feb 21, 2021

Opened a MR to update the astroid dependency: #4111

@Pierre-Sassoulas
Copy link
Member

pylint 2.7.0 has just been released and should be compatible with python 3.9 :)

@cdce8p
Copy link
Member

cdce8p commented Feb 21, 2021

@Pierre-Sassoulas Thanks for doing the release! I was just testing the new version on another project and noticed that pylint-dev/astroid#905 might be more of an issue than we though. Especially since we pinned the astroid version.

@hippo91 I haven't looked at the issue in detail yet, but what would be necessary to fix it?

@hippo91
Copy link
Contributor

hippo91 commented Feb 21, 2021

@Pierre-Sassoulas thanks for the release!
@cdce8p honestly i do not have any idea about the problem. I just think that reverting the faulty commit is not a solution.
I will try to have a look ASAP but it won t be before next week-end i think.

@juliangilbey
Copy link
Author

Thanks for your work on this, everyone! @sandrotosi has got it into Debian testing in time for the new release! Hugely appreciated 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants