Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only test write operations on a single Python version to avoid collision failures #333

Merged
merged 1 commit into from Jun 25, 2020

Conversation

hugovk
Copy link
Member

@hugovk hugovk commented Jun 24, 2020

Changes proposed in this pull request:

  • Because test are run using a real (test) account on Last.fm, sometimes one of the parallel jobs changes the state on the network and causes another job to fail (eg. last master https://travis-ci.org/github/pylast/pylast/builds/701542153)
  • Let's only do write tests with a single Python version/CI job (currently 3.8), to isolate potential conflicts

@hugovk hugovk added test Unit tests, linting, CI, etc. changelog: skip Exclude PR from release draft labels Jun 24, 2020
@codecov
Copy link

codecov bot commented Jun 24, 2020

Codecov Report

Merging #333 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #333   +/-   ##
=======================================
  Coverage   94.46%   94.46%           
=======================================
  Files           1        1           
  Lines        1265     1265           
=======================================
  Hits         1195     1195           
  Misses         70       70           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e7ad4ac...32461c0. Read the comment docs.

@hugovk hugovk merged commit 6f2bdb5 into master Jun 25, 2020
@hugovk hugovk deleted the isolate-write-tests branch June 25, 2020 05:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog: skip Exclude PR from release draft test Unit tests, linting, CI, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant