Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate Artist.get_cover_image, they're no longer available from Last.fm #332

Merged
merged 2 commits into from Jun 24, 2020

Conversation

hugovk
Copy link
Member

@hugovk hugovk commented Jun 22, 2020

Fixes #317.

Changes proposed in this pull request:

  • Last.fm announced that artist images were never meant to be available, in line with their API Terms of Use
  • They replaced the images with default star images
  • We therefore don't need to maintain Artist.get_cover_image in the future, so let's deprecate it first

@hugovk hugovk added deprecation Feature that will be removed in the future changelog: Deprecated For soon-to-be removed features labels Jun 22, 2020
@codecov
Copy link

codecov bot commented Jun 22, 2020

Codecov Report

Merging #332 into master will decrease coverage by 0.47%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #332      +/-   ##
==========================================
- Coverage   94.93%   94.46%   -0.48%     
==========================================
  Files           1        1              
  Lines        1264     1265       +1     
==========================================
- Hits         1200     1195       -5     
- Misses         64       70       +6     
Impacted Files Coverage Δ
src/pylast/__init__.py 94.46% <100.00%> (-0.48%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 108e3dd...e188e78. Read the comment docs.

@hugovk hugovk merged commit e7ad4ac into master Jun 24, 2020
@hugovk hugovk deleted the deprecate-artist.get_cover_image branch June 24, 2020 06:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog: Deprecated For soon-to-be removed features deprecation Feature that will be removed in the future
Projects
None yet
Development

Successfully merging this pull request may close these issues.

artist.get_cover_image always returns default star image
1 participant