Tutorial compare_with_external_photo

[miguelglezb]

Cannot unpack the output (tuple?) in argument np.unravel_index(i, sampling[0].shape) in:
sampling[:2, *np.unravel_index(i, sampling[0].shape)] = (

Every cell after this fails because of this issue.

[PabloCorcho]

I could not find any issue with the current version on main of this tutorial. Can you post which line of code is generating the error?

[miguelglezb]

This happens in the fourth cell and can be traced back to pykoala/corrections/external_data.py in line 107:

                ^
SyntaxError: invalid syntax

[PabloCorcho]

This issue should be fixed by now. @miguelglezb can you confirm that you do not have any problem when using the latest version of main?

[PabloCorcho]

If so, please close the issue 😄

[miguelglezb]

Still having the same issue, even with the latest version of main:

  File ~/koala/venv_koala/lib/python3.10/site-packages/IPython/core/interactiveshell.py:3577 in run_code
    exec(code_obj, self.user_global_ns, self.user_ns)

  Cell In[20],   [line 1](vscode-notebook-cell:?execution_count=20&line=1)
    from pykoala.corrections.external_data import AncillaryDataCorrection

  File ~/koala/venv_koala/lib/python3.10/site-packages/pykoala/corrections/external_data.py:107
    sampling[:2, *np.unravel_index(i, sampling[0].shape)] = (
                 ^
SyntaxError: invalid syntax

[PabloCorcho]

There was a compatibility issue between python3.11 and 3.10. I have fixed that in #425

[miguelglezb]

Notebook still failing but in fifth cell:

File ~/koala/venv_koala/lib/python3.10/site-packages/pykoala/corrections/external_data.py:387, in AncillaryDataCorrection.get_dc_aperture_fluxes(self, filter_names, dc_intensity_units, aperture_diameter, sample_every)
    [386](https://file+.vscode-resource.vscode-cdn.net/home/mbolivar/koala/tutorials/~/koala/venv_koala/lib/python3.10/site-packages/pykoala/corrections/external_data.py:386) try:
--> [387](https://file+.vscode-resource.vscode-cdn.net/home/mbolivar/koala/tutorials/~/koala/venv_koala/lib/python3.10/site-packages/pykoala/corrections/external_data.py:387)     from pst.observables import Filter
    [388](https://file+.vscode-resource.vscode-cdn.net/home/mbolivar/koala/tutorials/~/koala/venv_koala/lib/python3.10/site-packages/pykoala/corrections/external_data.py:388) except:

ModuleNotFoundError: No module named 'pst.observables'
``

[PabloCorcho]

Sorry Miguel, I missed that. That is a known issue. PST is a dependency of that particular correction and you haven't installed it. I will fix it once PST is on pypi. I am closing this issue and open a dedicated one for this.