Use public get_data_path for matplotlib hook #5568
Conversation
|
Well our CI/CD is using matplotlib 3.2.2 and that hasn't broken so that's a good start. To be honest, I'm unaware of any reason why we can't just use the generic |
There was a problem hiding this comment.
This needs a news entry.
Also can you spruce up the commit message? We've got quite a specific format going. Try git log-ing to get the idea.
on it
Certainly, I noticed that just after I made the PR. 🤦 I'll do a force push after the appveyor build passes. |
Private _get_data_path was removed in matplotlib-3.4.0rc1. This change simply removes the underscore to use the public version. (pyinstaller#5567)
richardsheridan
force-pushed
the
mpl_get_data_path
branch
from
71b21c6
to
4d9b2bc
Compare
|
... and I can confirm that this still work on matplotlib 2.2.2 which is several years ago. |
|
Thanks @richardsheridan. |
Private _get_data_path was removed in matplotlib-3.4.0rc1. This change simply removes the underscore to use the public version. (pyinstaller#5567)
Private _get_data_path was removed in matplotlib-3.4.0rc1. This change simply removes the underscore to use the public version. (pyinstaller#5567)
Fixes #5567. The bigger question is if this breaks earlier versions of matplotlib and how to deal with that if so.