New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Failure to correctly parse ldconfig
output
#5540
Comments
Yes, I guess it just needs a: if m is None:
continue That would however have the effect of silently ignoring lines in unrecognised syntax which could be a very subtle bug in future. |
Indeed. We could also print a warning for non-matched lines - but only for those that do not start with "Cache generated by: ", to avoid spam on known "problematic" lines. This change in output seems to come from introduction of an extension mechanism to ld.so.cache, so we'll probably need to expand the ignore list in the future. But this way, we can explicitly ignore the lines we know are harmless, and still catch new ones that could introduce bugs elsewhere... |
Mind testing my patch?
|
I confirm that it works now. |
I am here from #5552 and can confirm that your patch works but is giving me a 80mb file using |
I doubt a |
…-ci] (#5547) ldconfig has started adding additional lines of output such as: Cache generated by: ldconfig (GNU libc) release release version 2.33 which caused regex parse errors. This particular line is now whitelisted as skipable. And any future unrecognised patterns will now issue warnings.
Just run into this in my Arch. Really glad to see it's already handled. Thank you guys. |
What @LefterisJP said. |
I'd be for this. This issue seems to be collecting a fair bit of traffic. @htgoebel Could you do this? |
Friendly ping to request a minor version bump. |
Hopefully we'll be able to do a version bump soon, however please note that at the moment only Hartmut has the ability to do releases. |
Same here and the fix worked fine for me! |
I just stumbled upon this issue while trying to figure out what was going wrong in my system. I don't know if it can help for clarity but the issue came out of blue on my Arch-linux machine only. For our project we are using PyInstaller via fbs to package the PyQt app we are working on. Due to the limitations fbs imposes we are tied to PyInstaller version 3.4, the patch proposed by @bwoodsend works like a charm but I had to "hack my way in" by changing the version number to be able to use with my other packages. Is this something that was originated by an Arch update? Is there any way we can help to make this fix "retroactive"? |
This change in behavior is stemming from this commit to glibc, which was first released with glibc 2.33. So the "fix" is either to use latest PyInstaller, patch older PyInstaller versions, or downgrade glibc to earlier release (or use distribution that uses older version). |
). [skip-ci] (pyinstaller#5547) ldconfig has started adding additional lines of output such as: Cache generated by: ldconfig (GNU libc) release release version 2.33 which caused regex parse errors. This particular line is now whitelisted as skipable. And any future unrecognised patterns will now issue warnings.
). [skip-ci] (pyinstaller#5547) ldconfig has started adding additional lines of output such as: Cache generated by: ldconfig (GNU libc) release release version 2.33 which caused regex parse errors. This particular line is now whitelisted as skipable. And any future unrecognised patterns will now issue warnings.
I had a similar issue as @Kastakin while using |
Hit following errors when build on RHEL8: pyinstaller/pyinstaller#5540 Signed-off-by: Li Xi <pkuelelixi@163.com>
https://build.opensuse.org/request/show/920039 by user mcepl + dimstar_suse - Update to 4.5.1: large number of changes, see packaged CHANGES.rst for the complete list. - Remove glibc233.patch (included upstream) - Automagically skip matplotlib tests because matplotlib dropped python36 - Add glibc233.patch to fix recent test failure (gh#pyinstaller/pyinstaller#5540) - Disable functional tests as it takes ages and basic checks are okay with unittests - Use xdist for test execution as otherwise it takes ages - Requires python-devel, as `pyinstaller` cannot be used without it - Temporary disabled of tests test_egg* and test_nspkg1* - Update to version 3.6 * See changelog at https://github.com/pyinstaller/pyinstaller/blob/v3.6/doc/CHANGES.rst - Add %bcond_with python2 - Format with spec-cleaner, fix license - Delete upstream bootloaders from the source distributio
uhhh btw that link no more works anyone got a other link? |
The fix was already released, just install a newer PyInstaller version. |
If you are using fbs in its GPL licensed version and you are stuck with version 3.4 of Pyinstaller I would suggest you to look at PPG as an alternative |
The fix is not working for me . And i use pyinstaller 5.0.1 |
What does |
Description of the issue
Failure to correctly parse
ldconfig
output. Started happening after latestArch
upgrade. I guess theldconfig
people changed their output a little bit.Context information (for bug reports)
pyinstaller --version
:4.2
3.9
Arch
Stacktrace / full error message
It fails on the last line of this:
In
depend/utils.py
on line 402 no match check is being performed and the exception above is being thrown:The text was updated successfully, but these errors were encountered: