Hooks: Import correct typelib for GtkosxApplication #5475
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updates the hook to import the correct typelib instead of HarfBuzz. Also puts a guard in place to only use the hook when in macOS to prevent a traceback caused by an import error in Linux and Windows.
danyeaw
force-pushed
the
fix-gtkosx-traceback
branch
from
59a1904
to
4fb41ca
Compare
rokm
approved these changes
Jan 17, 2021
bwoodsend
approved these changes
Jan 17, 2021
Legorooj
approved these changes
Jan 27, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the hook to import the correct typelib instead of HarfBuzz.
Also puts a guard in place to only use the hook when in macOS to prevent a traceback caused by an import error in Linux and Windows: