-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Avoid unnecessary compiling disk path destinations entirely before including them from .py to .pyc into base_library.zip while using --onedir to build application. #5143
Comments
I'm sorry but you'll have to try to rephrase - I don't understand what you're saying.
This is how PyInstaller works - it includes compiled Python modules ( |
@bwoodsend I am not sure, but you can specify cause and make sure that |
Again, I don't understand what you're saying... |
@bwoodsend Is including the copy of embedded file from source path in .pyc? Instead, I should find out if is original source or source-embedded copy. |
Otherwise, you should close this issue. |
@web-sys1 can you include a screenshot of what you mean? It may clarify things. |
@Legorooj @bwoodsend This is an screenshot related to ”contents” of compiled |
Oh OK, I think I got it. You would like to include only revelant files in the archive, thoss actually used by your project and not the whole standard library. Right? |
Alright. |
@BoboTiG the whole std lib isn't included. Every file that's in |
@Legorooj yes I know, I just wanted to make the request clearer for everyone :) |
@Legorooj Have you done working on this? I've been waiting month-by-month to expect the results and I wonder that the repository is at point of new improvements. The last argument is enough to close the issue. |
Hmm, if this issue was actually not about collecting modules but rather about leaking source file paths in the compiled pyc modules that are collected into |
I'm not sure we ever did work out what the issue was but all the possible meanings I could see either already happen or shouldn't happen. |
Is your feature request related to a problem? Please describe.
I'm always frustrated when I want to build a one directory based python app while I use
--onedir
or--onefile
, thepyinstaller
(sub)command. Thebase_library.zip
archive contains a large number of .pyc files with encodings. However, the situation is odd, because it may include source path from computer entirely (for instance, it might settlec:\users\<username>\appdata\local\programs\python\<python-version>\lib\
in*.pyc
files of thatbase_library
archive), which becomes more confused.Describe the solution you'd like
Maybe, you should look to review the PyInstaller/building/makespec.py and entire package. When
--clean
command is set, it cleans Pyinstaller cache while building an executable app. An spec file should follow conditions: analyzing source files and its library, not includingc:\
entirely, but include compiled files what to be specified inbase_library
archive.The text was updated successfully, but these errors were encountered: