New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ask maintainers of (major) libraries to provide hook #5122
Comments
@htgoebel I'm already on this with numpy and matplotlib, and I've talked to the developers of both. My PRs should be open within the week. |
I'd suggest @Legorooj helping assign a dev to support package devs -- for example, perhaps he would help answer any numpy/sympy questions that team has, etc. I'd also suggest providing contact info in the submitted PR -- "this person will be happy to help you develop and maintain your hook" -- to get the ball rolling. |
Good idea! And of course we should provide any existing hook. |
Ok - which developers are willing to do this? I mean move a hook to it's supporting library (except numpy, matplotlib, cryptography, and pycryptodome; I'll do those), and offer continued support to that development team/person if they need help? You'll be able to ask for help from the rest of us you'd just be the primary contact for them. CC'ing @bwoodsend @vitsensei @amifunny @motatoes @rs357 @rokm @reritom |
I volunteer as a tribute @Legorooj |
I'm pretty familiar with the numpy and matplotlib hooks so happy to help with those two. The cryptography ones I've never even looked at so best give those to someone else... |
@bwoodsend feel free to take over on numpy and matplotlib - you're probably more familiar than I am. |
What things are needed to be told to maintainers of other libraries, in order for them to maintain the hooks? |
@amifunny https://pyinstaller.readthedocs.io/en/stable/hooks.html#provide-hooks-with-package should provide enough information. Other package's maintainers (OPMs ;-) are recommended to test their hooks against the current stable release of PyInstaller ( |
Also see the setup in hooks-contrib, which is very similar to what OPMs would need. |
Now that PyInstaller allows package developers to provide hooks with their packages, we might ask developers of other (major) packages to do so.
Template for a possible text (adobt you your needs and personal style :-):
The text was updated successfully, but these errors were encountered: