Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ask maintainers of (major) libraries to provide hook #5122

Open
htgoebel opened this issue Aug 29, 2020 · 11 comments
Open

Ask maintainers of (major) libraries to provide hook #5122

htgoebel opened this issue Aug 29, 2020 · 11 comments

Comments

@htgoebel
Copy link
Member

Now that PyInstaller allows package developers to provide hooks with their packages, we might ask developers of other (major) packages to do so.

Template for a possible text (adobt you your needs and personal style :-):

PyInstaller developer here.

PyInstaller includes a ["hook" for adapting it to the special needs and methods of XXX](https://pyinstaller.readthedocs.io/en/stable/hooks.html). This works quite well, anyway if XXX changes, it might take some time until PyInstaller catches up.

PyInstaller 4.0 (released a few weeks ago) added support for package developers to provide hooks with their packages. Thus numpy could deliver hooks including or excluding modules and files as needed. If you are interested in providing PyInstaller hooks with numpy, please have a look at [package developers to provide hooks with their packages](https://pyinstaller.readthedocs.io/en/stable/hooks.html#provide-hooks-with-package).
@htgoebel
Copy link
Member Author

numpy/numpy#17184

@htgoebel htgoebel added the good first issue This is a good issue if you want to start working on PyInstaller label Aug 29, 2020
@Legorooj
Copy link
Member

@htgoebel I'm already on this with numpy and matplotlib, and I've talked to the developers of both. My PRs should be open within the week.

@bjones1
Copy link
Contributor

bjones1 commented Aug 31, 2020

I'd suggest @Legorooj helping assign a dev to support package devs -- for example, perhaps he would help answer any numpy/sympy questions that team has, etc. I'd also suggest providing contact info in the submitted PR -- "this person will be happy to help you develop and maintain your hook" -- to get the ball rolling.

@htgoebel
Copy link
Member Author

Good idea! And of course we should provide any existing hook.

@Legorooj
Copy link
Member

Legorooj commented Sep 1, 2020

Ok - which developers are willing to do this? I mean move a hook to it's supporting library (except numpy, matplotlib, cryptography, and pycryptodome; I'll do those), and offer continued support to that development team/person if they need help? You'll be able to ask for help from the rest of us you'd just be the primary contact for them.

CC'ing @bwoodsend @vitsensei @amifunny @motatoes @rs357 @rokm @reritom

@motatoes
Copy link
Contributor

motatoes commented Sep 1, 2020

I volunteer as a tribute @Legorooj

@bwoodsend
Copy link
Member

I'm pretty familiar with the numpy and matplotlib hooks so happy to help with those two. The cryptography ones I've never even looked at so best give those to someone else...

@Legorooj
Copy link
Member

Legorooj commented Sep 1, 2020

@bwoodsend feel free to take over on numpy and matplotlib - you're probably more familiar than I am.

@amifunny
Copy link

amifunny commented Sep 1, 2020

What things are needed to be told to maintainers of other libraries, in order for them to maintain the hooks?

@htgoebel
Copy link
Member Author

htgoebel commented Sep 3, 2020

@amifunny https://pyinstaller.readthedocs.io/en/stable/hooks.html#provide-hooks-with-package should provide enough information. Other package's maintainers (OPMs ;-) are recommended to test their hooks against the current stable release of PyInstaller (pip install pyinstaller>=4.0, pinning this is not recommended) and the development branch pip install https://github.com/pyinstaller/pyinstaller/archive/develop.targ.bz2. An example can be found in https://github.com/pyinstaller/hooksample

@Legorooj
Copy link
Member

Legorooj commented Sep 4, 2020

Also see the setup in hooks-contrib, which is very similar to what OPMs would need.

@bwoodsend bwoodsend removed the good first issue This is a good issue if you want to start working on PyInstaller label Nov 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants