Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

archive_viewer enhancements (bugs) #2370

Closed
dshmgh opened this issue Jan 11, 2017 · 2 comments
Closed

archive_viewer enhancements (bugs) #2370

dshmgh opened this issue Jan 11, 2017 · 2 comments
Assignees
Labels
solution:duplicate Resolved: This issue is a duplicate.

Comments

@dshmgh
Copy link

dshmgh commented Jan 11, 2017

This affects the use of archive_viewer.py -- two issues:

  1. In the 3.2 release of pyinstaller in archive/readers.py at lines 147 and 149 there is a constant of 4096 hardcoded for the range of searching for the "MAGIC" value back from the end of the archive. In my case, I had a certificate of length 7248 bytes appended to the archive and it never found the "MAGIC" value location. Perhaps a better way is to start with 4096 and if MAGIC is not found, keep doubling the "EndBlockLength" and search again until the "EndBlockLength" is greater than the file length (or some algorithm like that).

  2. My windows .exe type archive still used the older 24 byte MAGIC cookie format and this release does not appear to support that. Perhaps that could be added back so that both formats are supported?
    See archive/readers.py lines 112, 155, 156, 167, 168

I am pretty new to Python so not sure my code would good enough for release purposes.

@htgoebel
Copy link
Member

Thanks for the report. Please submit a separate issue for each of the two topic, as they are different and differently important. Or even better: Submit a pull-request :-)

@htgoebel htgoebel added the @low label Jan 11, 2017
@dshmgh dshmgh closed this as completed Jan 11, 2017
@htgoebel
Copy link
Member

htgoebel commented Jan 12, 2017

Thanks :-) #2372, #2373

@htgoebel htgoebel added solution:duplicate Resolved: This issue is a duplicate. and removed @low labels Jan 12, 2017
@htgoebel htgoebel self-assigned this Jan 12, 2017
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
solution:duplicate Resolved: This issue is a duplicate.
Projects
None yet
Development

No branches or pull requests

2 participants