Improve support for cfgrib #746
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collect additional `xarray` backend plugins that are registered via `xarray.backends` entry-point (for example, `cfgrib`).
Add hook for `gribapi` package from `eccodes` dist, in order to collect bundled headers and ensure that the eccodes shared library is collected from the build environment.
rokm
force-pushed
the
hook-eccodes-gribapi
branch
from
1a9dd2d
to
a05d56c
Compare
|
Hmmm, looks like |
When determining the added and changed entries in the `requirements-test-libraries.txt`, use a combination of `diff`, `grep`, and `sed` to extract the relevant lines. We cannot use `diff --changed-group-format='%>' --unchanged-group-format=''`, because `--unchanged-group-format` is not available in Apple/FreeBSD `diff`, which is shipped with macOS Ventura and later.
bwoodsend
approved these changes
May 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extend the
xarrayhook to collect additional backend plugins that are registered via thexarray.backendsentry-point (e.g.,cfgrib).Add hook for
gribapipackage fromeccodesdist, in order to collect bundled headers and ensure that the eccodes shared library is collected from the build environment.Manually tested on Windows with Anaconda with program that tries to read a grib file.
The
test_eccodes_gribapimight pass on linux, but in reality, the collected shared library cannot yet be discovered (and so the system copy is used). For this to properly work, we will need to add an override for POSIX implementation ofctypes.util.find_libraryin PyInstaller's bootstrap/loader, which would explicitly search for matching filenames insys._MEIPASS.Closes #744.