New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Default fonts in img
formatter are backwards
#928
Comments
(Original comment by scolby33 on 2016-03-16T02:44:49.622307+00:00) See pull request #569 for my suggested solution. |
(Original comment by birkenfeld on 2016-03-16T06:00:52.322608+00:00) It is definitely intended that Vera is used on Unix, and Courier New on Windows; the documentation is wrong in this case. As for Mac OS X, #868 seems to imply that font selection is even more broken, and it needs a more comprehensive fix. |
(Original comment by scolby33 on 2016-03-16T06:03:12.667295+00:00) In that case, I believe a third case for font selection should be added, since by default Vera will not work on OS X and the package is broken out of the box. |
(Original comment by birkenfeld on 2016-03-16T06:17:09.394125+00:00) Sure. Which font is the best default nowadays? Menlo? |
(Original comment by birkenfeld on 2016-03-16T06:18:27.042323+00:00) (Should also change the Unix default to |
(Original comment by scolby33 on 2016-03-16T06:45:49.619696+00:00) From what I can tell, my default installation came with these monospaced fonts:
Courier lacks italics (it has obliques though). The default font used in Terminal is Menlo, which comes with Regular, Italic, Bold, and Bold Italic. |
87dc697 changes it to Deja Vu Sans ... now I need to update the docs, and then we can resolve this. For Mac OS, I assume you'd want Menlo? |
(Original issue 1221 created by scolby33 on 2016-03-16T02:33:26.073910+00:00)
In the documentation, it is stated that the default font for the
img
formatter is '“Bitstream Vera Sans Mono” on Windows, Courier New on *nix.'However, at lines 48-49 of pygments-main/pygments/formatters/img.py we have:
Bitstream Vera Sans Mono is not even shipped on OS X.
I think this is a duplicate of issue #868, but that has languished for two years now and, since this is such a simple fix, I figured I would bring it to attention again.
The text was updated successfully, but these errors were encountered: