New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add JavaScript Node.js Console Lexer #1825
Conversation
I find 'JavaScript Node.js console session' too ambiguous.
|
Can you please elaborate as to how this is ambiguous? What would you suggest? |
Yes, something like nodejsrepl. It's not really ambiguous, but it would be better to have a reference to 'REPL', without 'JavaScript'. For example: 'Node.js REPL session'. And the description: |
- renamed nodecon to nodejsrepl - removed bad mimetypes
Alias has been fixed, mimetypes have been reduced to text/x-nodejsrepl. I tried renaming the Lexer to NodeREPLLexer for consistency with this suggestion, but it breaks the tests cases -- the have a special condition in them for things named Console that seems to be needed here. I didn't dig any further, just put it back to NodeConsoleLexer. |
Merged, thanks for your contribution! |
I needed something like pycon for Node in a project I was working on, once written it was easy enough to put in here.
I've tested under py36 - py39. I don't have py35 or pypy installed, hopefully everything will work there.
Drop me a note if you need something formatted differently / more tests / whatever.
Thanks for the great tool!